Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1444283002: Reland "[heap] Turn on parallel compaction" (Closed)

Created:
5 years, 1 month ago by Michael Lippautz
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[heap] Turn on parallel compaction" This reverts commit e682048027b51dea5b1c9a970e09b8b2a99fcae6. BUG=chromium:524425 LOG=N CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg;tryserver.v8:v8_linux_gc_stress_dbg;tryserver.v8:v8_mac_gc_stress_dbg;tryserver.v8:v8_linux64_msan_rel;tryserver.v8:v8_linux64_tsan_rel Committed: https://crrev.com/c82d2323ffd5c399ba37da389ba0cdc72f46c97f Cr-Commit-Position: refs/heads/master@{#32009}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Hannes Payer (out of office)
Lgtm
5 years, 1 month ago (2015-11-16 11:05:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1444283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1444283002/1
5 years, 1 month ago (2015-11-16 13:53:30 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-16 14:30:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1444283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1444283002/1
5 years, 1 month ago (2015-11-16 14:35:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 14:37:03 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c82d2323ffd5c399ba37da389ba0cdc72f46c97f Cr-Commit-Position: refs/heads/master@{#32009}
5 years, 1 month ago (2015-11-16 14:37:23 UTC) #11
Michael Lippautz
5 years, 1 month ago (2015-11-16 15:36:00 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1445093002/ by mlippautz@chromium.org.

The reason for reverting is: Looks like tasks are still scheduled during isolate
shutdown after waiting for remaining tasks:
 
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20....

Powered by Google App Engine
This is Rietveld 408576698