content/browser/download/download_resource_handler.cc - Issue 1444253003: Use If-Range instead of If-Match/If-Unmodified-Since for partial requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_resource_handler.cc

Issue 1444253003: Use If-Range instead of If-Match/If-Unmodified-Since for partial requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make it obvious that the interrupt reason is obsolete. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/downloads.idl ('K') | « content/browser/download/download_manager_impl.cc ('k') | content/public/browser/download_interrupt_reason_values.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_resource_handler.cc

diff --git a/content/browser/download/download_resource_handler.cc b/content/browser/download/download_resource_handler.cc

index d806d9449330cbb7adce8c3f5743334936d37967..5f951dbcaa5583455c138f8e29ffe0310e74e424 100644

--- a/content/browser/download/download_resource_handler.cc

+++ b/content/browser/download/download_resource_handler.cc

@@ -408,11 +408,6 @@ void DownloadResourceHandler::OnResponseCompleted(

case net::HTTP_NOT_FOUND:

reason = DOWNLOAD_INTERRUPT_REASON_SERVER_BAD_CONTENT;

break;

- case net::HTTP_PRECONDITION_FAILED:

- // Failed our 'If-Unmodified-Since' or 'If-Match'; see

- // download_manager_impl.cc BeginDownload()

- reason = DOWNLOAD_INTERRUPT_REASON_SERVER_PRECONDITION;

- break;

case net::HTTP_REQUESTED_RANGE_NOT_SATISFIABLE:

// Retry by downloading from the start automatically:

// If we haven't received data when we get this error, we won't.