content/public/browser/download_interrupt_reason_values.h - Issue 1444253003: Use If-Range instead of If-Match/If-Unmodified-Since for partial requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/download_interrupt_reason_values.h

Issue 1444253003: Use If-Range instead of If-Match/If-Unmodified-Since for partial requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment indicating why the value 32 is missing in interrupt reasons list. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/browser/download_interrupt_reason_values.h

diff --git a/content/public/browser/download_interrupt_reason_values.h b/content/public/browser/download_interrupt_reason_values.h

index 92687b636f04ea831fbc8a1db4cebefdbc8477d9..f9036eb598171b9f0ae29d7bb7f0d30640e40c07 100644

--- a/content/public/browser/download_interrupt_reason_values.h

+++ b/content/public/browser/download_interrupt_reason_values.h

@@ -86,9 +86,11 @@ INTERRUPT_REASON(SERVER_FAILED, 30)

// Internal use only: must restart from the beginning.

INTERRUPT_REASON(SERVER_NO_RANGE, 31)

-// The download request does not meet the specified precondition.

-// Internal use only: the file has changed on the server.

-INTERRUPT_REASON(SERVER_PRECONDITION, 32)

+// Precondition failed. This type of interruption could legitimately occur if a

+// partial download resumption was attempted using a If-Match header. However,

+// the downloads logic no longer uses If-Match headers and instead uses If-Range

+// headers where a precondition failure is not expected.

+// INTERRUPT_REASON(SERVER_PRECONDITION, 32)

davidben 2015/11/23 17:35:37 Nit: Maybe do // Obsolete: INTERRUPT_REASON(...)

asanka 2015/11/23 22:01:11 Done. Went with the former.

// The server does not have the requested data.

// "Unable to get file".

« no previous file with comments | « content/browser/download/download_resource_handler.cc ('k') | net/tools/testserver/testserver.py » ('j') | no next file with comments »