Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: content/public/browser/download_interrupt_reason_values.h

Issue 1444253003: Use If-Range instead of If-Match/If-Unmodified-Since for partial requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make it obvious that the interrupt reason is obsolete. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Note that the embedder is welcome to persist these values across 5 // Note that the embedder is welcome to persist these values across
6 // invocations of the browser, and possibly across browser versions. 6 // invocations of the browser, and possibly across browser versions.
7 // Thus individual errors may be deprecated and new errors added, but 7 // Thus individual errors may be deprecated and new errors added, but
8 // the values of particular errors should not be changed. 8 // the values of particular errors should not be changed.
9 9
10 // File errors. 10 // File errors.
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 // Server responses. 79 // Server responses.
80 80
81 // The server indicates that the operation has failed (generic). 81 // The server indicates that the operation has failed (generic).
82 // "Server Error". 82 // "Server Error".
83 INTERRUPT_REASON(SERVER_FAILED, 30) 83 INTERRUPT_REASON(SERVER_FAILED, 30)
84 84
85 // The server does not support range requests. 85 // The server does not support range requests.
86 // Internal use only: must restart from the beginning. 86 // Internal use only: must restart from the beginning.
87 INTERRUPT_REASON(SERVER_NO_RANGE, 31) 87 INTERRUPT_REASON(SERVER_NO_RANGE, 31)
88 88
89 // The download request does not meet the specified precondition. 89 // Precondition failed. This type of interruption could legitimately occur if a
90 // Internal use only: the file has changed on the server. 90 // partial download resumption was attempted using a If-Match header. However,
91 INTERRUPT_REASON(SERVER_PRECONDITION, 32) 91 // the downloads logic no longer uses If-Match headers and instead uses If-Range
92 // headers where a precondition failure is not expected.
93 //
94 // Obsolete: INTERRUPT_REASON(SERVER_PRECONDITION, 32)
92 95
93 // The server does not have the requested data. 96 // The server does not have the requested data.
94 // "Unable to get file". 97 // "Unable to get file".
95 INTERRUPT_REASON(SERVER_BAD_CONTENT, 33) 98 INTERRUPT_REASON(SERVER_BAD_CONTENT, 33)
96 99
97 // Server didn't authorize access to resource. 100 // Server didn't authorize access to resource.
98 INTERRUPT_REASON(SERVER_UNAUTHORIZED, 34) 101 INTERRUPT_REASON(SERVER_UNAUTHORIZED, 34)
99 102
100 // Server certificate problem. 103 // Server certificate problem.
101 INTERRUPT_REASON(SERVER_CERT_PROBLEM, 35) 104 INTERRUPT_REASON(SERVER_CERT_PROBLEM, 35)
(...skipping 10 matching lines...) Expand all
112 // The user shut down the browser. 115 // The user shut down the browser.
113 // Internal use only: resume pending downloads if possible. 116 // Internal use only: resume pending downloads if possible.
114 INTERRUPT_REASON(USER_SHUTDOWN, 41) 117 INTERRUPT_REASON(USER_SHUTDOWN, 41)
115 118
116 119
117 // Crash. 120 // Crash.
118 121
119 // The browser crashed. 122 // The browser crashed.
120 // Internal use only: resume pending downloads if possible. 123 // Internal use only: resume pending downloads if possible.
121 INTERRUPT_REASON(CRASH, 50) 124 INTERRUPT_REASON(CRASH, 50)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698