Make NSSCertDatabase::ListCerts work async on a worker thread.

chromeos/cert_loader.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/cert_loader.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/location.h"
-#include "base/sequenced_task_runner.h"
+#include "base/message_loop/message_loop_proxy.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/task_runner_util.h"
 #include "base/threading/worker_pool.h"
 #include "crypto/nss_util.h"
 #include "net/cert/nss_cert_database.h"
 #include "net/cert/nss_cert_database_chromeos.h"
 #include "net/cert/x509_certificate.h"
 
 namespace chromeos {
 
-namespace {
-
-// Loads certificates from |cert_database| into |cert_list|.
-void LoadNSSCertificates(net::NSSCertDatabase* cert_database,
-                         net::CertificateList* cert_list) {
-  cert_database->ListCerts(cert_list);
-}
-
-}  // namespace
-
 static CertLoader* g_cert_loader = NULL;
 
 // static
 void CertLoader::Initialize() {
   CHECK(!g_cert_loader);
   g_cert_loader = new CertLoader();
 }
 
 // static
 void CertLoader::Shutdown() {
@@ skipping 35 matching lines @@
   // directly, as |database_| observers receive only events generated directly
   // by |database_|, so they may miss a few relevant ones.
   // TODO(tbarzic): Once singleton NSSCertDatabase is removed, investigate if
   // it would be OK to observe |database_| directly; or change NSSCertDatabase
   // to send notification on all relevant changes.
   net::CertDatabase::GetInstance()->AddObserver(this);
 
   LoadCertificates();
 }
 
-void CertLoader::SetSlowTaskRunnerForTest(
-    const scoped_refptr<base::TaskRunner>& task_runner) {
-  slow_task_runner_for_test_ = task_runner;
-}
-
 void CertLoader::AddObserver(CertLoader::Observer* observer) {
   observers_.AddObserver(observer);
 }
 
 void CertLoader::RemoveObserver(CertLoader::Observer* observer) {
   observers_.RemoveObserver(observer);
 }
 
 int CertLoader::TPMTokenSlotID() const {
   if (!database_)
@@ skipping 48 matching lines @@
 
 void CertLoader::LoadCertificates() {
   CHECK(thread_checker_.CalledOnValidThread());
   VLOG(1) << "LoadCertificates: " << certificates_update_running_;
 
   if (certificates_update_running_) {
     certificates_update_required_ = true;
     return;
   }
 
-  net::CertificateList* cert_list = new net::CertificateList;
   certificates_update_running_ = true;
   certificates_update_required_ = false;
 
-  base::TaskRunner* task_runner = slow_task_runner_for_test_.get();
-  if (!task_runner)
-    task_runner = base::WorkerPool::GetTaskRunner(true /* task is slow */);
-  task_runner->PostTaskAndReply(
-      FROM_HERE,
-      base::Bind(LoadNSSCertificates,
-                 // Create a copy of the database so it can be used on the
-                 // worker pool.
-                 // TODO(tbarzic): Make net::NSSCertDatabase::ListCerts async
-                 //     and change it to do the certificate listing on worker
-                 //     pool.
-                 base::Owned(new net::NSSCertDatabaseChromeOS(
-                     database_->GetPublicSlot(),
-                     database_->GetPrivateSlot())),
-                 cert_list),
-      base::Bind(&CertLoader::UpdateCertificates,
-                 weak_factory_.GetWeakPtr(),
-                 base::Owned(cert_list)));
+  database_->ListCerts(base::Bind(&CertLoader::UpdateCertificates,
+                       weak_factory_.GetWeakPtr()));

[stevenjb, 2014/02/04 22:28:42]

nit: align

[tbarzic, 2014/02/04 23:12:38]

Done.

 }
 
-void CertLoader::UpdateCertificates(net::CertificateList* cert_list) {
+void CertLoader::UpdateCertificates(
+    scoped_ptr<net::CertificateList> cert_list) {
   CHECK(thread_checker_.CalledOnValidThread());
   DCHECK(certificates_update_running_);
   VLOG(1) << "UpdateCertificates: " << cert_list->size();
 
   // Ignore any existing certificates.
   cert_list_.swap(*cert_list);

[stevenjb, 2014/02/04 22:28:42]

cert_list.release() to make the ownership transfer clear. Better yet would be to
make cert_list_ a scoped_ptr<> and Pass() cert_list (but that looks like it
would be a bigger change, so fine not to do that here).

[tbarzic, 2014/02/04 23:12:38]

It's not that bigger.. Done.

 
   bool initial_load = !certificates_loaded_;
   certificates_loaded_ = true;
   NotifyCertificatesLoaded(initial_load);
 
   certificates_update_running_ = false;
   if (certificates_update_required_)
     LoadCertificates();
 }
 
@@ skipping 13 matching lines @@
   VLOG(1) << "OnCertAdded";
   LoadCertificates();
 }
 
 void CertLoader::OnCertRemoved(const net::X509Certificate* cert) {
   VLOG(1) << "OnCertRemoved";
   LoadCertificates();
 }
 
 }  // namespace chromeos