Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 144423006: Rewrite release event only if press event was rewritten for a given device. (Closed)

Created:
6 years, 11 months ago by oshima
Modified:
6 years, 10 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Rewrite release event only if press event was rewritten for a given device. BUG=330567 TEST=EventRewriterTest.DontRewriteIfNotRewritten Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247912

Patch Set 1 : #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : addressed comment #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -14 lines) Patch
M chrome/browser/ui/ash/event_rewriter.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/event_rewriter.cc View 1 2 1 chunk +9 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/event_rewriter_unittest.cc View 1 5 chunks +80 lines, -1 line 0 comments Download
M ui/events/test/events_test_utils_x11.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/test/events_test_utils_x11.cc View 1 2 3 5 chunks +38 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
oshima
yusukes@, how does this look? I'll add test if this is ok.
6 years, 11 months ago (2014-01-24 01:23:26 UTC) #1
oshima
On 2014/01/24 01:23:26, oshima wrote: > yusukes@, how does this look? > > I'll add ...
6 years, 11 months ago (2014-01-27 17:14:29 UTC) #2
Yusuke Sato
On 2014/01/27 17:14:29, oshima wrote: > On 2014/01/24 01:23:26, oshima wrote: > > yusukes@, how ...
6 years, 10 months ago (2014-01-29 09:16:56 UTC) #3
oshima
sadrul, can you review this?
6 years, 10 months ago (2014-01-30 01:50:52 UTC) #4
sadrul
https://codereview.chromium.org/144423006/diff/130001/ui/events/test/events_test_utils_x11.cc File ui/events/test/events_test_utils_x11.cc (right): https://codereview.chromium.org/144423006/diff/130001/ui/events/test/events_test_utils_x11.cc#newcode31 ui/events/test/events_test_utils_x11.cc:31: int XButtonNum(int flags) { Could you use XButtonEventButton() instead? ...
6 years, 10 months ago (2014-01-30 02:01:42 UTC) #5
oshima
PTAL https://codereview.chromium.org/144423006/diff/130001/ui/events/test/events_test_utils_x11.cc File ui/events/test/events_test_utils_x11.cc (right): https://codereview.chromium.org/144423006/diff/130001/ui/events/test/events_test_utils_x11.cc#newcode31 ui/events/test/events_test_utils_x11.cc:31: int XButtonNum(int flags) { On 2014/01/30 02:01:42, sadrul ...
6 years, 10 months ago (2014-01-30 02:12:53 UTC) #6
sadrul
LGTM. Thanks! https://codereview.chromium.org/144423006/diff/150001/ui/events/test/events_test_utils_x11.cc File ui/events/test/events_test_utils_x11.cc (right): https://codereview.chromium.org/144423006/diff/150001/ui/events/test/events_test_utils_x11.cc#newcode42 ui/events/test/events_test_utils_x11.cc:42: */ Just remove this.
6 years, 10 months ago (2014-01-30 02:14:21 UTC) #7
oshima
https://codereview.chromium.org/144423006/diff/150001/ui/events/test/events_test_utils_x11.cc File ui/events/test/events_test_utils_x11.cc (right): https://codereview.chromium.org/144423006/diff/150001/ui/events/test/events_test_utils_x11.cc#newcode42 ui/events/test/events_test_utils_x11.cc:42: */ On 2014/01/30 02:14:21, sadrul wrote: > Just remove ...
6 years, 10 months ago (2014-01-30 02:16:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/144423006/170001
6 years, 10 months ago (2014-01-30 02:21:12 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=254021
6 years, 10 months ago (2014-01-30 04:47:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/144423006/170001
6 years, 10 months ago (2014-01-30 05:43:28 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 09:16:37 UTC) #12
Message was sent while issue was closed. 
Change committed as 247912

Powered by Google App Engine
This is Rietveld 408576698