Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: Source/modules/webmidi/MIDIOutput.cpp

Issue 14442004: Web MIDI: implement MIDIOutput (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: crogers review Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webmidi/MIDIOutput.cpp
diff --git a/Source/core/platform/chromium/SearchPopupMenuChromium.cpp b/Source/modules/webmidi/MIDIOutput.cpp
similarity index 64%
copy from Source/core/platform/chromium/SearchPopupMenuChromium.cpp
copy to Source/modules/webmidi/MIDIOutput.cpp
index 203221eb21ced417ddb9e5090436ef77d3576d92..d234a186d4dad9f9a355bb33450441c2c7688850 100644
--- a/Source/core/platform/chromium/SearchPopupMenuChromium.cpp
+++ b/Source/modules/webmidi/MIDIOutput.cpp
@@ -1,6 +1,5 @@
/*
- * Copyright (c) 2008, 2009, Google Inc. All rights reserved.
- * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
+ * Copyright (C) 2013 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
@@ -30,36 +29,31 @@
*/
#include "config.h"
-#include "core/platform/chromium/SearchPopupMenuChromium.h"
-
-#include "core/platform/NotImplemented.h"
-#include <wtf/text/AtomicString.h>
+#include "modules/webmidi/MIDIOutput.h"
namespace WebCore {
-SearchPopupMenuChromium::SearchPopupMenuChromium(PopupMenuClient* client)
- : m_popup(adoptRef(new PopupMenuChromium(client)))
-{
-}
-
-PopupMenu* SearchPopupMenuChromium::popupMenu()
+PassRefPtr<MIDIOutput> MIDIOutput::create(ScriptExecutionContext* context, const String& id, const String& manufacturer, const String& name, const String& version)
{
- return m_popup.get();
+ return adoptRef(new MIDIOutput(context, id, manufacturer, name, version));
}
-bool SearchPopupMenuChromium::enabled()
+MIDIOutput::MIDIOutput(ScriptExecutionContext* context, const String& id, const String& manufacturer, const String& name, const String& version)
+ : MIDIPort(context, id, manufacturer, name, MIDIPortTypeOutput, version)
{
- return false;
}
-void SearchPopupMenuChromium::saveRecentSearches(const AtomicString& name, const Vector<String>& searchItems)
+void MIDIOutput::send(Uint8Array* data, double timestamp)
{
- notImplemented();
+ // FIXME: Implement MIDI protocol validation here. System exclusive
+ // messages must be checked at the same time.
+ // Actual sending operation will be implemented in core/platform/midi.
}
-void SearchPopupMenuChromium::loadRecentSearches(const AtomicString& name, Vector<String>& searchItems)
+void MIDIOutput::send(Vector<unsigned int>, double timestamp)
{
- notImplemented();
+ // FIXME: Ditto. Implementation will be shared between these two send
+ // functions.
}
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698