Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: third_party/WebKit/Source/core/loader/NavigationScheduler.h

Issue 1444183003: Cancel javascript: URL navigations if the frame was navigated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/NavigationScheduler.h
diff --git a/third_party/WebKit/Source/core/loader/NavigationScheduler.h b/third_party/WebKit/Source/core/loader/NavigationScheduler.h
index 2551ef6b5faf96a86b2e0d95272c7dec5c137b25..71a64fb78ac2cc4a15124a6d2a7d82f24a689373 100644
--- a/third_party/WebKit/Source/core/loader/NavigationScheduler.h
+++ b/third_party/WebKit/Source/core/loader/NavigationScheduler.h
@@ -75,13 +75,8 @@ public:
DECLARE_TRACE();
private:
- friend class FrameNavigationDisabler;
explicit NavigationScheduler(LocalFrame*);
- void disableFrameNavigation() { ++m_navigationDisableCount; }
- void enableFrameNavigation() { --m_navigationDisableCount; }
- bool isFrameNavigationAllowed() const { return !m_navigationDisableCount; }
-
bool shouldScheduleReload() const;
bool shouldScheduleNavigation(const String& url) const;
@@ -93,7 +88,6 @@ private:
RawPtrWillBeMember<LocalFrame> m_frame;
OwnPtr<CancellableTaskFactory> m_navigateTaskFactory;
OwnPtrWillBeMember<ScheduledNavigation> m_redirect;
- int m_navigationDisableCount;
};
class NavigationDisablerForBeforeUnload {
@@ -115,17 +109,6 @@ private:
static unsigned s_navigationDisableCount;
};
-class FrameNavigationDisabler {
- WTF_MAKE_NONCOPYABLE(FrameNavigationDisabler);
- STACK_ALLOCATED();
-public:
- explicit FrameNavigationDisabler(LocalFrame*);
- ~FrameNavigationDisabler();
-
-private:
- RawPtrWillBeMember<NavigationScheduler> m_navigationScheduler;
-};
-
} // namespace blink
#endif // NavigationScheduler_h
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | third_party/WebKit/Source/core/loader/NavigationScheduler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698