Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1503)

Unified Diff: chrome/browser/android/data_usage/data_use_tab_model.h

Issue 1444133002: Add UMA histograms for data usage tab model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/data_usage/data_use_tab_model.h
diff --git a/chrome/browser/android/data_usage/data_use_tab_model.h b/chrome/browser/android/data_usage/data_use_tab_model.h
index 43a07bdb110c5a8ac329cb20af38617e10afe9e3..8f663f4f79b00c1e1075c8a5999d5c2de79fe154 100644
--- a/chrome/browser/android/data_usage/data_use_tab_model.h
+++ b/chrome/browser/android/data_usage/data_use_tab_model.h
@@ -77,7 +77,7 @@ class DataUseTabModel {
DataUseTabModel(const ExternalDataUseObserver* data_use_observer,
scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner);
- ~DataUseTabModel();
+ virtual ~DataUseTabModel();
base::WeakPtr<DataUseTabModel> GetWeakPtr();
@@ -110,19 +110,22 @@ class DataUseTabModel {
private:
friend class DataUseTabModelTest;
friend class MockTabDataUseEntryTest;
- FRIEND_TEST_ALL_PREFIXES(DataUseTabModelTest, SingleTabTracking);
- FRIEND_TEST_ALL_PREFIXES(DataUseTabModelTest, MultipleTabTracking);
- FRIEND_TEST_ALL_PREFIXES(DataUseTabModelTest, ObserverStartEndEvents);
- FRIEND_TEST_ALL_PREFIXES(DataUseTabModelTest, ObserverNotNotifiedAfterRemove);
- FRIEND_TEST_ALL_PREFIXES(DataUseTabModelTest,
- MultipleObserverMultipleStartEndEvents);
FRIEND_TEST_ALL_PREFIXES(DataUseTabModelTest, TabCloseEvent);
FRIEND_TEST_ALL_PREFIXES(DataUseTabModelTest, TabCloseEventEndsTracking);
FRIEND_TEST_ALL_PREFIXES(DataUseTabModelTest,
CompactTabEntriesWithinMaxLimit);
+ FRIEND_TEST_ALL_PREFIXES(MockDataUseTabModelTest,
+ UnexpiredTabEntryRemovaltimeHistogram);
+ FRIEND_TEST_ALL_PREFIXES(MockDataUseTabModelTest,
+ ExpiredInactiveTabEntryRemovaltimeHistogram);
+ FRIEND_TEST_ALL_PREFIXES(MockDataUseTabModelTest,
+ ExpiredActiveTabEntryRemovaltimeHistogram);
typedef base::hash_map<int32_t, TabDataUseEntry> TabEntryMap;
+ // Virtualized for unit test support.
+ virtual base::TimeTicks Now() const;
tbansal1 2015/11/16 17:17:38 #include base/time/time.h and remove the include f
Raj 2015/11/16 20:09:36 Done.
+
// Returns the maximum number of tab entries to maintain session information
// about.
static size_t GetMaxTabEntriesForTests();

Powered by Google App Engine
This is Rietveld 408576698