Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1597)

Unified Diff: mojo/runner/BUILD.gn

Issue 1444113003: GN: asset_location -> android_assets() for mojo_runner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@html_viewer-assets
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/mojo_application.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/runner/BUILD.gn
diff --git a/mojo/runner/BUILD.gn b/mojo/runner/BUILD.gn
index 0fe40cbf6c84bad324310864edef9fb7a4072524..1496e4e3cfa0da5c1e77c3defbc58941df81dd8f 100644
--- a/mojo/runner/BUILD.gn
+++ b/mojo/runner/BUILD.gn
@@ -268,54 +268,26 @@ if (is_android) {
custom_package = "org.chromium.mojo.shell"
}
- mojo_runner_test_assets_dir = "$root_build_dir/mojo_runner_test_assets"
- mojo_runner_apptests_assets_dir =
- "$root_build_dir/mojo_runner_apptests_assets"
-
- copy_ex("copy_mojo_runner_apptests_assets") {
+ android_assets("mojo_runner_apptests_assets") {
testonly = true
- clear_dir = true
- dest = mojo_runner_apptests_assets_dir
deps = [
":bootstrap",
":bootstrap_java",
- "//components/clipboard:apptests",
- "//components/mus/ws:apptests",
- "//components/resource_provider:apptests",
- "//mojo/services/network:apptests",
- "//third_party/icu:icudata",
+ "//components/clipboard:apptests_assets",
+ "//components/clipboard:clipboard_assets",
+ "//components/mus/ws:apptests_assets",
+ "//components/resource_provider:apptests_assets",
+ "//components/resource_provider:resource_provider_assets",
+ "//mojo/services/network:apptests_assets",
+ "//mojo/services/network:network_assets",
+ "//third_party/icu:icu_assets",
]
sources = [
"$root_out_dir/obj/mojo/runner/bootstrap_java.dex.jar",
"$root_shlib_dir/${shlib_prefix}bootstrap$shlib_extension",
]
-
- apptest_outputs = [
- "clipboard",
- "clipboard_apptests",
- "icudtl.dat",
- "mus_apptests",
- "resource_provider",
- "resource_provider_apptests",
- "network_service",
- "network_service_apptests",
- ]
-
- args = []
- foreach(path, apptest_outputs) {
- args +=
- [ "--files=" + rebase_path("$root_out_dir/$path", root_build_dir) ]
- }
- }
-
- generate_mojo_shell_assets_list("build_mojo_runner_apptests_assets") {
- testonly = true
- deps = [
- ":copy_mojo_runner_apptests_assets",
- ]
- dir = mojo_runner_apptests_assets_dir
}
copy("copy_mojo_runner") {
@@ -330,48 +302,21 @@ if (is_android) {
]
}
- copy_ex("copy_mojo_runner_test_assets") {
- testonly = true
- clear_dir = true
- dest = mojo_runner_test_assets_dir
- deps = [
- "//mojo/services/test_service:test_app",
- "//mojo/services/test_service:test_request_tracker_app",
- "//third_party/icu:icudata",
- ]
-
- # Directories can't be specified as sources so pass manually to the script.
- args = [
- "--files=" + rebase_path("$root_out_dir/icudtl.dat", root_build_dir),
- "--files=" + rebase_path("$root_out_dir/test_app", root_build_dir),
- "--files=" +
- rebase_path("$root_out_dir/test_request_tracker_app", root_build_dir),
- ]
- }
-
android_apk("mojo_runner_apptests_apk") {
testonly = true
apk_name = "MojoRunnerApptests"
android_manifest = "android/apk/AndroidManifest.xml"
native_libs = [ "${shlib_prefix}mojo_runner$shlib_extension" ]
- asset_location = mojo_runner_apptests_assets_dir
+ write_asset_list = true
deps = [
- ":build_mojo_runner_apptests_assets",
":copy_mojo_runner",
":java",
+ ":mojo_runner_apptests_assets",
":resources",
"//base:base_java",
"//ui/platform_window/android:platform_window_java",
google_play_services_resources,
]
}
-
- generate_mojo_shell_assets_list("build_mojo_runner_test_assets") {
- testonly = true
- deps = [
- ":copy_mojo_runner_test_assets",
- ]
- dir = mojo_runner_test_assets_dir
- }
}
« no previous file with comments | « mojo/public/mojo_application.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698