A direct dependent of this project should also use the x64 version of

A direct dependent of this project should also use the x64 version of
opensslconf.h when building for the x64 target.

R=agl@chromium.org,davidben@chromium.org,rsleevi@chromium.org
BUG=none
TEST=none

[Ryan Sleevi, 2014-02-05 02:13:03]

https://codereview.chromium.org/144383010/diff/20001/openssl.gyp
File openssl.gyp (right):

https://codereview.chromium.org/144383010/diff/20001/openssl.gyp#newcode89
openssl.gyp:89: 'openssl_public_include_dirs+': [ 'config/x64' ],
Is the public API affected by this (eg: including opensslconf.h)?

The way we've dealt with this in other third-party projects is to ensure the
#defines are included within the .gyp file, not the config.h file - or that the
config.h is only used internally when generating the library.

[Ryan Sleevi, 2014-02-05 02:14:53]

Never mind, I just realized that OpenSSL always uses a fully qualified include
(that is <openssl/opensslconf.h> )

LGTM

[wtc, 2014-02-05 17:14:32]

https://codereview.chromium.org/144383010/diff/20001/openssl.gyp
File openssl.gyp (right):

https://codereview.chromium.org/144383010/diff/20001/openssl.gyp#newcode89
openssl.gyp:89: 'openssl_public_include_dirs+': [ 'config/x64' ],

On 2014/02/05 02:13:03, Ryan Sleevi wrote:
> Is the public API affected by this (eg: including opensslconf.h)?

opensslconf.h is the only header under the config/x64 directory. (It's in an
"openssl" subdirectory.) So this change won't make other headers available to a
direct dependent.

opensslconf.h is a public header. (For example, on a Ubuntu Linux computer,
opensslconf.h is in /usr/include/openssl.) I don't think it is usually included
directly, but several public headers include it.

[wtc, 2014-02-05 17:14:35]

The CQ bit was checked by wtc@chromium.org

[commit-bot: I haz the power, 2014-02-05 17:14:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/144383010/20001

[commit-bot: I haz the power, 2014-02-05 17:14:56]

Change committed as 249030