Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 144383008: Implement retry for Register call in GCMNetworkChannel (Closed)

Created:
6 years, 10 months ago by pavely
Modified:
6 years, 10 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Implement retry for Register call in GCMNetworkChannel When Register fails with transient erro retry with exponential backoff. BUG=335670 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248872

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -26 lines) Patch
M sync/notifier/gcm_network_channel.h View 3 chunks +7 lines, -0 lines 0 comments Download
M sync/notifier/gcm_network_channel.cc View 3 chunks +62 lines, -4 lines 0 comments Download
M sync/notifier/gcm_network_channel_unittest.cc View 7 chunks +67 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pavely
6 years, 10 months ago (2014-02-04 02:28:38 UTC) #1
rlarocque
lgtm
6 years, 10 months ago (2014-02-04 18:18:03 UTC) #2
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 10 months ago (2014-02-04 18:31:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/144383008/1
6 years, 10 months ago (2014-02-04 18:36:46 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=256847
6 years, 10 months ago (2014-02-04 20:23:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/144383008/1
6 years, 10 months ago (2014-02-04 20:25:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/144383008/1
6 years, 10 months ago (2014-02-05 00:50:28 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 06:15:57 UTC) #8
Message was sent while issue was closed. 
Change committed as 248872

Powered by Google App Engine
This is Rietveld 408576698