[GCM] Fix mcs_probe credential handling

[GCM] Fix mcs_probe credential handling

The mcs probe was no longer consuming credentials passed via command line
switch properly. This fixes it so that if credentials as passed, they're
used, otherwise if the credentials are restored they are used, and lastly
if no credentials are found a checkin is performed.

BUG=284553
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247248

[Nicolas Zea, 2014-01-25 00:54:36]

PTAL

[jianli, 2014-01-25 01:00:28]

https://codereview.chromium.org/144383005/diff/1/google_apis/gcm/tools/mcs_pr...
File google_apis/gcm/tools/mcs_probe.cc (right):

https://codereview.chromium.org/144383005/diff/1/google_apis/gcm/tools/mcs_pr...
google_apis/gcm/tools/mcs_probe.cc:290:
gcm_store_->SetDeviceCredentials(android_id_,
Should we persist the check-in info when the check-in completes
(MCSProbe::OnCheckInCompleted)?

[Nicolas Zea, 2014-01-25 01:04:13]

https://codereview.chromium.org/144383005/diff/1/google_apis/gcm/tools/mcs_pr...
File google_apis/gcm/tools/mcs_probe.cc (right):

https://codereview.chromium.org/144383005/diff/1/google_apis/gcm/tools/mcs_pr...
google_apis/gcm/tools/mcs_probe.cc:290:
gcm_store_->SetDeviceCredentials(android_id_,
On 2014/01/25 01:00:28, jianli wrote:
> Should we persist the check-in info when the check-in completes
> (MCSProbe::OnCheckInCompleted)?

Good point, done.

[jianli, 2014-01-25 01:07:12]

lgtm

[fgorski, 2014-01-25 01:09:28]

On 2014/01/25 01:07:12, jianli wrote:
> lgtm

lgtm

[commit-bot: I haz the power, 2014-01-27 13:44:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zea@chromium.org/144383005/70001

[commit-bot: I haz the power, 2014-01-27 16:23:59]

Change committed as 247248