Make SkAndroidCodec support bmp

src/codec/SkSampledCodec.cpp

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkCodec.h"
 #include "SkCodecPriv.h"
 #include "SkMath.h"
@@ skipping 208 matching lines @@
                     if (!fCodec->skipScanlines(sampleY - 1)) {
                         fCodec->fillIncompleteImage(info, pixels, rowBytes,
                                 options.fZeroInitialized, dstHeight, y + 1);
                         return SkCodec::kIncompleteInput;
                     }
                 }
                 pixelPtr = SkTAddOffset<void>(pixelPtr, rowBytes);
             }
             return SkCodec::kSuccess;
         }
+        case SkCodec::kBottomUp_SkScanlineOrder: {
+            // Note that this mode does not support subsetting.
+            SkASSERT(0 == subsetY && nativeSize.height() == subsetHeight);
+            int y;
+            for (y = 0; y < nativeSize.height(); y++) {
+                int srcY = fCodec->nextScanline();
+                if (is_coord_necessary(srcY, sampleY, dstHeight)) {
+                    void* pixelPtr = SkTAddOffset<void>(pixels,
+                            rowBytes * get_dst_coord(srcY, sampleY));
+                    if (1 != fCodec->getScanlines(pixelPtr, 1, rowBytes)) {
+                        break;
+                    }
+                } else {
+                    if (!fCodec->skipScanlines(1)) {
+                        break;
+                    }
+                }
+            }
+
+            if (nativeSize.height() == y) {
+              return SkCodec::kSuccess;

[scroggo, 2015/11/17 16:13:58]

nit: four space indent

(Joke's on you for copying my comments exactly!)

[msarett, 2015/11/17 16:24:27]

:).  Not the first time I've fallen for this.

+            }
+
+            // We handle filling uninitialized memory here instead of using fCodec.
+            // fCodec does not know that we are sampling.
+            const uint32_t fillValue = fCodec->getFillValue(info.colorType(), info.alphaType());
+            for (; y < nativeSize.height(); y++) {
+                int srcY = fCodec->outputScanline(y);
+                if (is_coord_necessary(srcY, sampleY, dstHeight)) {

[scroggo, 2015/11/17 16:13:58]

nit: You could give yourself a little extra width (and maybe make your
statements on one line) if you change this if:

if (!is_coord_necessary(...)) {
    continue;
}
void* pixelPtr ...

Fine as-is though.

[msarett, 2015/11/17 16:24:27]

sgtm

+                    void* pixelPtr = SkTAddOffset<void>(pixels,
+                            rowBytes * get_dst_coord(srcY, sampleY));
+                    SkSampler::Fill(info.makeWH(info.width(), 1), pixelPtr, rowBytes, fillValue,

[scroggo, 2015/11/17 16:13:58]

nit: I think you should create this info once outside the loop.

[msarett, 2015/11/17 16:24:27]

Done.

+                            options.fZeroInitialized);
+                }
+            }
+            return SkCodec::kIncompleteInput;
+        }
         case SkCodec::kNone_SkScanlineOrder: {
             const int linesNeeded = subsetHeight - samplingOffsetY;
             SkAutoMalloc storage(linesNeeded * rowBytes);
             uint8_t* storagePtr = static_cast<uint8_t*>(storage.get());
 
             if (!fCodec->skipScanlines(startY)) {
                 fCodec->fillIncompleteImage(info, pixels, rowBytes, options.fZeroInitialized,
                         dstHeight, 0);
                 return SkCodec::kIncompleteInput;
             }
             int scanlines = fCodec->getScanlines(storagePtr, linesNeeded, rowBytes);
 
             for (int y = 0; y < dstHeight; y++) {
                 memcpy(pixels, storagePtr, info.minRowBytes());
                 storagePtr += sampleY * rowBytes;
                 pixels = SkTAddOffset<void>(pixels, rowBytes);
             }
 
             if (scanlines < dstHeight) {
                 // fCodec has already handled filling uninitialized memory.
                 return SkCodec::kIncompleteInput;
             }
             return SkCodec::kSuccess;
         }
         default:
             SkASSERT(false);
             return SkCodec::kUnimplemented;
     }
 }