Use label name to generate PDB names in GN.

Use label name to generate PDB names in GN.

On Windows the GN toolchain setup used the output name to make unique PDB names. But the output name isn't necessarily that unique. The only requirement on that is that the outputs not collide, but multiple targets can otherwise have the same output name. Also, the output name can contain slashes that put it in different directories, or spaces which might confuse certain tools.

The label name is guaranteed to be unique in a given target_out_dir so this should give better names.

Committed: https://crrev.com/62b96626799d935ec467c5104f2da5b8ce080592
Cr-Commit-Position: refs/heads/master@{#359677}

[brettw, 2015-11-13 21:08:22]

Description was changed from

==========
Use label name to generate PDB names in GN.

On Windows the GN toolchain setup used the output name to make unique PDB names.
But the output name isn't necessarily that unique. The only requirement on that
is that the outputs not collide, but multiple targets can otherwise have the
same output name.

The label name is guaranteed to be unique in a given target_out_dir so this
should give better names.
==========

to

==========
Use label name to generate PDB names in GN.

On Windows the GN toolchain setup used the output name to make unique PDB names.
But the output name isn't necessarily that unique. The only requirement on that
is that the outputs not collide, but multiple targets can otherwise have the
same output name. Also, the output name can contain slashes that put it in
different directories, or spaces which might confuse certain tools.

The label name is guaranteed to be unique in a given target_out_dir so this
should give better names.
==========

[brettw, 2015-11-13 21:08:35]

brettw@chromium.org changed reviewers:
+ jam@chromium.org

[brettw, 2015-11-13 21:08:39]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-13 21:09:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1443733003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1443733003/1

[jam, 2015-11-13 21:43:59]

lgtm if you verified this?

[Dirk Pranke, 2015-11-13 22:02:47]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2015-11-13 22:02:47]

lgtm.

I agree that label_name is better than target_output_name regardless of whether
it fixes jam's problem or not.

[commit-bot: I haz the power, 2015-11-13 22:09:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-13 22:09:30]

Dry run: This issue passed the CQ dry run.

[jam, 2015-11-13 22:33:23]

On 2015/11/13 22:02:47, Dirk Pranke wrote:
> lgtm.
> 
> I agree that label_name is better than target_output_name regardless of
whether
> it fixes jam's problem or not.

ben confirmed it works

[jam, 2015-11-13 22:33:24]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2015-11-13 22:35:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1443733003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1443733003/1

[commit-bot: I haz the power, 2015-11-13 22:52:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-13 22:53:37]

Patchset 1 (id:??) landed as
https://crrev.com/62b96626799d935ec467c5104f2da5b8ce080592
Cr-Commit-Position: refs/heads/master@{#359677}