Revert of Fix NTP thumbnail generation

Revert of Fix NTP thumbnail generation (patchset #13 id:260001 of https://codereview.chromium.org/1348833003/ )

Reason for revert:
possible culprit of an uninit error

BUG=555567
TBR=shrike@chromium.org

Original issue's description:
> Fix NTP thumbnail generation
> 
> This change delays browser compositor view suspention until pending
> thumbnail generation has completed.
> 
> This solution uses polling to check if it's OK to suspend the
> compositor, which is not great. Also, there's a potential race condition
> between the user foregrounding the tab and the pending suspension.
> Ideally the thumnail generation operation would signal the compositor
> that it's OK to proceed with its suspension, and the compositor would only
> suspend itself if it has not been reactivated. I'm just not sure of the
> best way to approach that.
> 
> BUG=530707
> 
> Committed: https://crrev.com/d77a3639f04f83a5c5cf47d88dbac2f0d4345ea5
> Cr-Commit-Position: refs/heads/master@{#359361}

TBR=ccameron@chromium.org,thestig@chromium.org,motek@chromium.org,shrike@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=530707

[zhaoqin, 2015-11-13 15:55:32]

Created Revert of Fix NTP thumbnail generation

[commit-bot: I haz the power, 2015-11-13 15:55:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1443723002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1443723002/1

[commit-bot: I haz the power, 2015-11-13 15:55:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-13 15:55:58]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[zhaoqin, 2015-11-13 17:41:36]

shrike, could you please take a look at this issue crbug.com/555567

[shrike, 2015-11-13 17:59:00]

On 2015/11/13 17:41:36, zhaoqin wrote:
> shrike, could you please take a look at this issue crbug.com/555567

Hello zhaoqin,

I have looked at it and I believe I understand the problem. I have a fix, but
I'm not sure how to proceed given that you have begun the process of reverting
my cl (although it looks like the revert did not land). Please advise....

[zhaoqin, 2015-11-13 18:15:19]

On 2015/11/13 17:59:00, shrike wrote:
> On 2015/11/13 17:41:36, zhaoqin wrote:
> > shrike, could you please take a look at this issue crbug.com/555567
> 
> Hello zhaoqin,
> 
> I have looked at it and I believe I understand the problem. I have a fix, but
> I'm not sure how to proceed given that you have begun the process of reverting
> my cl (although it looks like the revert did not land). Please advise....

the revert did not get in, so if you have a quick fix to be committed soon, we
can just forget the revert and wait for the real fix instead.

[shrike, 2015-11-13 18:17:39]

On 2015/11/13 18:15:19, zhaoqin wrote:
> On 2015/11/13 17:59:00, shrike wrote:
> > On 2015/11/13 17:41:36, zhaoqin wrote:
> > > shrike, could you please take a look at this issue crbug.com/555567
> > 
> > Hello zhaoqin,
> > 
> > I have looked at it and I believe I understand the problem. I have a fix,
but
> > I'm not sure how to proceed given that you have begun the process of
reverting
> > my cl (although it looks like the revert did not land). Please advise....
> 
> the revert did not get in, so if you have a quick fix to be committed soon, we
> can just forget the revert and wait for the real fix instead.

OK, that's easy - let me get a cl up.

[shrike, 2015-11-13 18:36:41]

On 2015/11/13 18:17:39, shrike wrote:
> On 2015/11/13 18:15:19, zhaoqin wrote:
> > On 2015/11/13 17:59:00, shrike wrote:
> > > On 2015/11/13 17:41:36, zhaoqin wrote:
> > > > shrike, could you please take a look at this issue crbug.com/555567
> > > 
> > > Hello zhaoqin,
> > > 
> > > I have looked at it and I believe I understand the problem. I have a fix,
> but
> > > I'm not sure how to proceed given that you have begun the process of
> reverting
> > > my cl (although it looks like the revert did not land). Please advise....
> > 
> > the revert did not get in, so if you have a quick fix to be committed soon,
we
> > can just forget the revert and wait for the real fix instead.
> 
> OK, that's easy - let me get a cl up.

Please see https://codereview.chromium.org/1445433005

[Lei Zhang, 2015-11-19 00:09:01]

Description was changed from

==========
Revert of Fix NTP thumbnail generation (patchset #13 id:260001 of
https://codereview.chromium.org/1348833003/ )

Reason for revert:
possible culprit of an uninit error

BUG=555567
TBR=shrike@chromium.org

Original issue's description:
> Fix NTP thumbnail generation
> 
> This change delays browser compositor view suspention until pending
> thumbnail generation has completed.
> 
> This solution uses polling to check if it's OK to suspend the
> compositor, which is not great. Also, there's a potential race condition
> between the user foregrounding the tab and the pending suspension.
> Ideally the thumnail generation operation would signal the compositor
> that it's OK to proceed with its suspension, and the compositor would only
> suspend itself if it has not been reactivated. I'm just not sure of the
> best way to approach that.
> 
> BUG=530707
> 
> Committed: https://crrev.com/d77a3639f04f83a5c5cf47d88dbac2f0d4345ea5
> Cr-Commit-Position: refs/heads/master@{#359361}

TBR=ccameron@chromium.org,thestig@chromium.org,motek@chromium.org,shrike@chro...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=530707
==========

to

==========
Revert of Fix NTP thumbnail generation (patchset #13 id:260001 of
https://codereview.chromium.org/1348833003/ )

Reason for revert:
possible culprit of an uninit error

BUG=555567
TBR=shrike@chromium.org

Original issue's description:
> Fix NTP thumbnail generation
> 
> This change delays browser compositor view suspention until pending
> thumbnail generation has completed.
> 
> This solution uses polling to check if it's OK to suspend the
> compositor, which is not great. Also, there's a potential race condition
> between the user foregrounding the tab and the pending suspension.
> Ideally the thumnail generation operation would signal the compositor
> that it's OK to proceed with its suspension, and the compositor would only
> suspend itself if it has not been reactivated. I'm just not sure of the
> best way to approach that.
> 
> BUG=530707
> 
> Committed: https://crrev.com/d77a3639f04f83a5c5cf47d88dbac2f0d4345ea5
> Cr-Commit-Position: refs/heads/master@{#359361}

TBR=ccameron@chromium.org,thestig@chromium.org,motek@chromium.org,shrike@chro...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=530707
==========