chrome/browser/android/data_usage/external_data_use_observer.cc - Issue 1443683002: Notify DataUseTabModel of navigations and tab closures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/data_usage/external_data_use_observer.cc

Issue 1443683002: Notify DataUseTabModel of navigations and tab closures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed sclittle comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/data_usage/data_use_ui_tab_model.cc ('K') | « chrome/browser/android/data_usage/external_data_use_observer.h ('k') | chrome/browser/profiles/profile_impl_io_data.cc » ('j') | chrome/browser/profiles/profile_impl_io_data.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/data_usage/external_data_use_observer.cc

diff --git a/chrome/browser/android/data_usage/external_data_use_observer.cc b/chrome/browser/android/data_usage/external_data_use_observer.cc

index aeaee32760c51f0929f74e27f27de025ed22d688..96b48a84c0603d2d6ef07246c9a0d49654c9b202 100644

--- a/chrome/browser/android/data_usage/external_data_use_observer.cc

+++ b/chrome/browser/android/data_usage/external_data_use_observer.cc

@@ -105,6 +105,7 @@ ExternalDataUseObserver::ExternalDataUseObserver(

// |this| owns and must outlive the |data_use_tab_model_|.

data_use_tab_model_.reset(new DataUseTabModel(this, ui_task_runner_));

+ data_use_tab_model_weak_ptr_ = data_use_tab_model_->GetWeakPtr();

matching_rules_fetch_pending_ = true;

data_use_aggregator_->AddObserver(this);