chrome/browser/android/data_usage/data_use_tab_model.cc - Issue 1443683002: Notify DataUseTabModel of navigations and tab closures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/data_usage/data_use_tab_model.cc

Issue 1443683002: Notify DataUseTabModel of navigations and tab closures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: patch Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/data_usage/data_use_tab_model.h ('k') | chrome/browser/android/data_usage/data_use_ui_tab_model.h » ('j') | chrome/browser/android/data_usage/data_use_ui_tab_model.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/data_usage/data_use_tab_model.cc

diff --git a/chrome/browser/android/data_usage/data_use_tab_model.cc b/chrome/browser/android/data_usage/data_use_tab_model.cc

index c4d8e36e39e2716ec47af99ce4fe3453efac5227..9e836d13e7a02f2568665804b853adb7155ddfa8 100644

--- a/chrome/browser/android/data_usage/data_use_tab_model.cc

+++ b/chrome/browser/android/data_usage/data_use_tab_model.cc

@@ -47,12 +47,10 @@ base::WeakPtr<DataUseTabModel> DataUseTabModel::GetWeakPtr() {

void DataUseTabModel::OnNavigationEvent(int32_t tab_id,

TransitionType transition,

- const GURL& url,

- const std::string& package) {

+ const GURL& url) {

DCHECK(thread_checker_.CalledOnValidThread());

DCHECK(IsValidTabID(tab_id));

- // TODO(rajendrant): implementation to use package.

switch (transition) {

case TRANSITION_OMNIBOX_SEARCH:

case TRANSITION_FROM_EXTERNAL_APP: {