chrome/browser/android/data_usage/external_data_use_observer.h - Issue 1443683002: Notify DataUseTabModel of navigations and tab closures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/data_usage/external_data_use_observer.h

Issue 1443683002: Notify DataUseTabModel of navigations and tab closures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased, addressed comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/data_usage/data_use_ui_tab_model.cc ('K') | « chrome/browser/android/data_usage/data_use_ui_tab_model_unittest.cc ('k') | chrome/browser/io_thread.h » ('j') | chrome/browser/io_thread.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/data_usage/external_data_use_observer.h

diff --git a/chrome/browser/android/data_usage/external_data_use_observer.h b/chrome/browser/android/data_usage/external_data_use_observer.h

index 6a9c8382b88f1da13f015b503e4e8d6814a86f1f..26e2ae21b0a1e6af941409cfad55c1042cb94a2a 100644

--- a/chrome/browser/android/data_usage/external_data_use_observer.h

+++ b/chrome/browser/android/data_usage/external_data_use_observer.h

@@ -96,6 +96,7 @@ class ExternalDataUseObserver : public data_usage::DataUseAggregator::Observer {

}

private:

+ // TODO(tbansal): Alphabetize this.

FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, SingleRegex);

FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, TwoRegex);

FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, MultipleRegex);

@@ -112,6 +113,7 @@ class ExternalDataUseObserver : public data_usage::DataUseAggregator::Observer {

PeriodicFetchMatchingRules);

FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, BufferDataUseReports);

FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, Variations);

+ FRIEND_TEST_ALL_PREFIXES(DataUseUITabModelTest, ReportTabEventsTest);

// DataUseReportKey is a unique identifier for a data use report.

struct DataUseReportKey {