Notify DataUseTabModel of navigations and tab closures

chrome/browser/android/data_usage/data_use_tab_model.cc

Index: chrome/browser/android/data_usage/data_use_tab_model.cc
diff --git a/chrome/browser/android/data_usage/data_use_tab_model.cc b/chrome/browser/android/data_usage/data_use_tab_model.cc
index c4d8e36e39e2716ec47af99ce4fe3453efac5227..ffadd699b1f68810ee009c1e2d156cd5e7d89672 100644
--- a/chrome/browser/android/data_usage/data_use_tab_model.cc
+++ b/chrome/browser/android/data_usage/data_use_tab_model.cc
@@ -7,6 +7,7 @@
 #include "base/time/time.h"
 #include "chrome/browser/android/data_usage/external_data_use_observer.h"
 #include "chrome/browser/android/data_usage/tab_data_use_entry.h"
+#include "content/public/browser/browser_thread.h"
 
 namespace {
 
@@ -33,7 +34,6 @@ DataUseTabModel::DataUseTabModel(
     const ExternalDataUseObserver* data_use_observer,
     scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner)
     : data_use_observer_(data_use_observer),
-      observer_list_(new base::ObserverListThreadSafe<TabDataUseObserver>),
       weak_factory_(this) {}
 
 DataUseTabModel::~DataUseTabModel() {
@@ -47,14 +47,13 @@ base::WeakPtr<DataUseTabModel> DataUseTabModel::GetWeakPtr() {
 
 void DataUseTabModel::OnNavigationEvent(int32_t tab_id,
                                         TransitionType transition,
-                                        const GURL& url,
-                                        const std::string& package) {
+                                        const GURL& url) {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(IsValidTabID(tab_id));
 
-  // TODO(rajendrant): implementation to use package.
   switch (transition) {
     case TRANSITION_OMNIBOX_SEARCH:
+    case TRANSITION_OMNIBOX_NAVIGATION:
     case TRANSITION_FROM_EXTERNAL_APP: {
       // Enter events.
       std::string label;
@@ -69,7 +68,6 @@ void DataUseTabModel::OnNavigationEvent(int32_t tab_id,
     }
 
     case TRANSITION_FROM_NAVSUGGEST:
-    case TRANSITION_OMNIBOX_NAVIGATION:
     case TRANSITION_BOOKMARK:
     case TRANSITION_HISTORY_ITEM:
     case TRANSITION_TO_EXTERNAL_APP:
@@ -118,21 +116,21 @@ bool DataUseTabModel::GetLabelForDataUse(const data_usage::DataUse& data_use,
 }
 
 void DataUseTabModel::AddObserver(TabDataUseObserver* observer) {
-  observer_list_->AddObserver(observer);
+  observer_list_.AddObserver(observer);

[sclittle, 2015/11/18 21:42:03]

nit: Add DCHECK(thread_checker_.CalledOnValidThread());

[tbansal1, 2015/11/19 00:47:06]

Done.

 }
 
 void DataUseTabModel::RemoveObserver(TabDataUseObserver* observer) {
-  observer_list_->RemoveObserver(observer);
+  observer_list_.RemoveObserver(observer);

[sclittle, 2015/11/18 21:42:03]

nit: Add DCHECK(thread_checker_.CalledOnValidThread());

[tbansal1, 2015/11/19 00:47:06]

Done.

 }
 
 void DataUseTabModel::NotifyObserversOfTrackingStarting(int32_t tab_id) {
-  observer_list_->Notify(FROM_HERE, &TabDataUseObserver::NotifyTrackingStarting,
-                         tab_id);
+  FOR_EACH_OBSERVER(TabDataUseObserver, observer_list_,

[sclittle, 2015/11/18 21:42:03]

nit: Add DCHECK(thread_checker_.CalledOnValidThread());

[tbansal1, 2015/11/19 00:47:06]

Done.

+                    NotifyTrackingStarting(tab_id));
 }
 
 void DataUseTabModel::NotifyObserversOfTrackingEnding(int32_t tab_id) {
-  observer_list_->Notify(FROM_HERE, &TabDataUseObserver::NotifyTrackingEnding,
-                         tab_id);
+  FOR_EACH_OBSERVER(TabDataUseObserver, observer_list_,

[sclittle, 2015/11/18 21:42:03]

nit: Add DCHECK(thread_checker_.CalledOnValidThread());

same with the other methods

[tbansal1, 2015/11/19 00:47:06]

Done.

+                    NotifyTrackingEnding(tab_id));
 }
 
 void DataUseTabModel::StartTrackingDataUse(int32_t tab_id,