Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: chrome/browser/android/data_usage/external_data_use_observer.h

Issue 1443683002: Notify DataUseTabModel of navigations and tab closures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments, Using two weak ptrs now. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/data_usage/external_data_use_observer.h
diff --git a/chrome/browser/android/data_usage/external_data_use_observer.h b/chrome/browser/android/data_usage/external_data_use_observer.h
index 5caa6208526299d8cb02637e4a92c9e600e1ef46..22d459cd0a902095eebaf3d31e9eb46c47c4a494 100644
--- a/chrome/browser/android/data_usage/external_data_use_observer.h
+++ b/chrome/browser/android/data_usage/external_data_use_observer.h
@@ -91,6 +91,10 @@ class ExternalDataUseObserver : public data_usage::DataUseAggregator::Observer {
// matching rule's label.
bool Matches(const GURL& gurl, std::string* label) const;
+ DataUseTabModel* data_use_tab_model() const {
sclittle 2015/11/16 23:13:43 Why does this need to be exposed here?
tbansal1 2015/11/17 21:12:33 It is called in io_thread.cc
+ return data_use_tab_model_.get();
+ }
+
private:
FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, SingleRegex);
FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, TwoRegex);
@@ -108,6 +112,7 @@ class ExternalDataUseObserver : public data_usage::DataUseAggregator::Observer {
PeriodicFetchMatchingRules);
FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, BufferDataUseReports);
FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, Variations);
+ FRIEND_TEST_ALL_PREFIXES(DataUseUITabModelTest, ReportTabEventsTest);
// DataUseReportKey is a unique identifier for a data use report.
struct DataUseReportKey {

Powered by Google App Engine
This is Rietveld 408576698