Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: chrome/browser/android/data_usage/data_use_tab_helper.h

Issue 1443683002: Notify DataUseTabModel of navigations and tab closures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments, Using two weak ptrs now. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/data_usage/data_use_tab_helper.h
diff --git a/chrome/browser/android/data_usage/data_use_tab_helper.h b/chrome/browser/android/data_usage/data_use_tab_helper.h
index 041c8534fc52ab27c2b3b798867473a5d1d3b9df..e35aeb7f12924e028ca549523bc5fc044c5a3a65 100644
--- a/chrome/browser/android/data_usage/data_use_tab_helper.h
+++ b/chrome/browser/android/data_usage/data_use_tab_helper.h
@@ -27,9 +27,9 @@ class DataUseTabHelper : public content::WebContentsObserver,
explicit DataUseTabHelper(content::WebContents* web_contents);
// Overridden from content::WebContentsObserver:
- void ReadyToCommitNavigation(
+ void DidFinishNavigation(
content::NavigationHandle* navigation_handle) override;
- void FrameDeleted(content::RenderFrameHost* render_frame_host) override;
+ void RenderFrameDeleted(content::RenderFrameHost* render_frame_host) override;
DISALLOW_COPY_AND_ASSIGN(DataUseTabHelper);
};

Powered by Google App Engine
This is Rietveld 408576698