Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: chrome/browser/android/data_usage/data_use_ui_tab_model_unittest.cc

Issue 1443683002: Notify DataUseTabModel of navigations and tab closures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/data_usage/data_use_ui_tab_model.h" 5 #include "chrome/browser/android/data_usage/data_use_ui_tab_model.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/message_loop/message_loop.h"
10 #include "base/run_loop.h"
11 #include "chrome/browser/android/data_usage/data_use_tab_model.h"
9 #include "chrome/browser/android/data_usage/data_use_ui_tab_model_factory.h" 12 #include "chrome/browser/android/data_usage/data_use_ui_tab_model_factory.h"
13 #include "chrome/browser/android/data_usage/external_data_use_observer.h"
10 #include "chrome/browser/profiles/profile.h" 14 #include "chrome/browser/profiles/profile.h"
11 #include "chrome/browser/sessions/session_tab_helper.h" 15 #include "chrome/browser/sessions/session_tab_helper.h"
12 #include "chrome/test/base/chrome_render_view_host_test_harness.h" 16 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
17 #include "components/data_usage/core/data_use.h"
18 #include "components/data_usage/core/data_use_aggregator.h"
19 #include "components/data_usage/core/data_use_amortizer.h"
20 #include "components/data_usage/core/data_use_annotator.h"
21 #include "content/public/browser/browser_thread.h"
13 #include "content/public/browser/web_contents.h" 22 #include "content/public/browser/web_contents.h"
14 #include "content/public/test/test_renderer_host.h" 23 #include "content/public/test/test_renderer_host.h"
15 #include "content/public/test/web_contents_tester.h" 24 #include "content/public/test/web_contents_tester.h"
16 #include "testing/gtest/include/gtest/gtest.h" 25 #include "testing/gtest/include/gtest/gtest.h"
17 #include "ui/base/page_transition_types.h" 26 #include "ui/base/page_transition_types.h"
18 #include "url/gurl.h" 27 #include "url/gurl.h"
19 28
20 namespace chrome { 29 namespace chrome {
21 30
22 namespace android { 31 namespace android {
23 32
33 class TestDataUseTabModel : public DataUseTabModel {
34 public:
35 TestDataUseTabModel(
36 ExternalDataUseObserver* external_data_use_observer,
37 scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner)
38 : DataUseTabModel(external_data_use_observer, ui_task_runner),
39 weak_factory_(this) {}
40
41 base::WeakPtr<TestDataUseTabModel> GetWeakPtr() {
42 return weak_factory_.GetWeakPtr();
43 }
44
45 using DataUseTabModel::NotifyObserversOfTrackingStarting;
46 using DataUseTabModel::NotifyObserversOfTrackingEnding;
47
48 private:
49 base::WeakPtrFactory<TestDataUseTabModel> weak_factory_;
50 };
51
24 class DataUseUITabModelTest : public ChromeRenderViewHostTestHarness { 52 class DataUseUITabModelTest : public ChromeRenderViewHostTestHarness {
25 public: 53 public:
26 using ChromeRenderViewHostTestHarness::web_contents; 54 using ChromeRenderViewHostTestHarness::web_contents;
27 55
28 DataUseUITabModel* data_use_ui_tab_model() { 56 DataUseUITabModel* data_use_ui_tab_model() {
57 DataUseUITabModel* data_use_ui_tab_model = data_use_ui_tab_model_private();
58 base::RunLoop().RunUntilIdle();
59 return data_use_ui_tab_model;
60 }
61
62 scoped_refptr<base::SingleThreadTaskRunner> io_task_runner() const {
63 return io_task_runner_;
64 }
65
66 scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner() const {
67 return ui_task_runner_;
68 }
69
70 ExternalDataUseObserver* external_data_use_observer() const {
71 return external_data_use_observer_.get();
72 }
73
74 TestDataUseTabModel* data_use_tab_model() const {
75 return data_use_tab_model_.get();
76 }
77
78 protected:
79 void SetUp() override {
80 ChromeRenderViewHostTestHarness::SetUp();
81
82 io_task_runner_ = content::BrowserThread::GetMessageLoopProxyForThread(
83 content::BrowserThread::IO);
84 ui_task_runner_ = content::BrowserThread::GetMessageLoopProxyForThread(
85 content::BrowserThread::UI);
86
87 data_use_aggregator_.reset(
88 new data_usage::DataUseAggregator(nullptr, nullptr));
89
90 external_data_use_observer_.reset(new ExternalDataUseObserver(
91 data_use_aggregator_.get(), io_task_runner(), ui_task_runner()));
92 base::RunLoop().RunUntilIdle();
93
94 data_use_tab_model_.reset(new TestDataUseTabModel(
95 external_data_use_observer(),
96 content::BrowserThread::GetMessageLoopProxyForThread(
97 content::BrowserThread::UI)));
98 }
99
100 private:
101 DataUseUITabModel* data_use_ui_tab_model_private() {
29 return chrome::android::DataUseUITabModelFactory::GetForBrowserContext( 102 return chrome::android::DataUseUITabModelFactory::GetForBrowserContext(
30 Profile::FromBrowserContext(web_contents()->GetBrowserContext())); 103 Profile::FromBrowserContext(web_contents()->GetBrowserContext()));
31 } 104 }
105
106 scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_;
107 scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
108 scoped_ptr<data_usage::DataUseAggregator> data_use_aggregator_;
109 scoped_ptr<ExternalDataUseObserver> external_data_use_observer_;
110 scoped_ptr<TestDataUseTabModel> data_use_tab_model_;
32 }; 111 };
33 112
34 // Tests that DataUseTabModel is notified of tab closure and navigation events. 113 // Tests that DataUseTabModel is notified of tab closure and navigation events,
114 // and DataUseTabModel notifies DataUseUITabModel.
35 TEST_F(DataUseUITabModelTest, ReportTabEventsTest) { 115 TEST_F(DataUseUITabModelTest, ReportTabEventsTest) {
36 data_use_ui_tab_model()->ReportBrowserNavigation( 116 std::string foo_label("foo_label");
37 GURL("https://www.example.com"), 117
38 ui::PageTransition::PAGE_TRANSITION_TYPED, 118 std::vector<std::string> url_regexes;
39 SessionTabHelper::IdForTab(web_contents())); 119 url_regexes.push_back(
40 data_use_ui_tab_model()->ReportTabClosure( 120 "http://www[.]foo[.]com/#q=.*|https://www[.]foo[.]com/#q=.*");
41 SessionTabHelper::IdForTab(web_contents())); 121 external_data_use_observer()->RegisterURLRegexes(
42 // TODO(tbansal): Test that DataUseTabModel is notified. 122 std::vector<std::string>(url_regexes.size(), std::string()), url_regexes,
123 std::vector<std::string>(url_regexes.size(), foo_label));
124
125 data_use_ui_tab_model()->SetIODataUseTabModel(
126 data_use_tab_model()->GetWeakPtr());
127
128 const struct {
129 ui::PageTransition transition_type;
130 std::string expected_label;
131 } tests[] = {
132 {ui::PageTransitionFromInt(ui::PageTransition::PAGE_TRANSITION_LINK |
133 ui::PAGE_TRANSITION_FROM_API),
134 std::string()},
135 {ui::PageTransition::PAGE_TRANSITION_LINK, std::string()},
136 {ui::PageTransition::PAGE_TRANSITION_TYPED, foo_label},
137 {ui::PageTransition::PAGE_TRANSITION_AUTO_BOOKMARK, std::string()},
138 {ui::PageTransition::PAGE_TRANSITION_AUTO_TOPLEVEL, std::string()},
139 {ui::PageTransition::PAGE_TRANSITION_GENERATED, foo_label},
140 {ui::PageTransition::PAGE_TRANSITION_RELOAD, std::string()},
141 };
142
143 for (size_t i = 0; i < arraysize(tests); ++i) {
144 // Start a new tab.
145 int32_t foo_tab_id = i + 1;
146 data_use_ui_tab_model()->ReportBrowserNavigation(
147 GURL("https://www.foo.com/#q=abc"), tests[i].transition_type,
148 foo_tab_id);
149 base::RunLoop().RunUntilIdle();
150
151 // |data_use_ui_tab_model| should receive callback about starting of
152 // tracking of data usage for |foo_tab_id|.
153 EXPECT_EQ(!tests[i].expected_label.empty(),
154 data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id))
155 << i;
156 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id))
157 << i;
158 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingEnded(foo_tab_id))
159 << i;
160
161 // DataUse object should be labeled correctly.
162 data_usage::DataUse data_use(GURL("http://foo.com/#q=abc"),
163 base::TimeTicks::Now(),
164 GURL("http://foobar.com"), foo_tab_id,
165 net::NetworkChangeNotifier::CONNECTION_UNKNOWN,
166 std::string(), 1000, 1000);
167 std::string got_label;
168 data_use_tab_model()->GetLabelForDataUse(data_use, &got_label);
169 EXPECT_EQ(tests[i].expected_label, got_label) << i;
170
171 // Report closure of tab.
172 data_use_ui_tab_model()->ReportTabClosure(foo_tab_id);
173 base::RunLoop().RunUntilIdle();
174
175 // DataUse object should not be labeled.
176 data_use.request_start =
177 base::TimeTicks::Now() + base::TimeDelta::FromMinutes(10);
178 data_use_tab_model()->GetLabelForDataUse(data_use, &got_label);
179 EXPECT_EQ(std::string(), got_label) << i;
180 }
43 } 181 }
44 182
45 // Tests if the Entrance/Exit UI state is tracked correctly. 183 // Tests if the Entrance/Exit UI state is tracked correctly.
46 TEST_F(DataUseUITabModelTest, EntranceExitState) { 184 TEST_F(DataUseUITabModelTest, EntranceExitState) {
185 data_use_ui_tab_model()->SetIODataUseTabModel(
186 data_use_tab_model()->GetWeakPtr());
187
47 int32_t foo_tab_id = 1; 188 int32_t foo_tab_id = 1;
48 int32_t bar_tab_id = 2; 189 int32_t bar_tab_id = 2;
49 int32_t baz_tab_id = 3; 190 int32_t baz_tab_id = 3;
50 191
51 // ShowEntrance should return true only once. 192 ASSERT_NE(data_use_ui_tab_model(), nullptr);
52 data_use_ui_tab_model()->OnTrackingStarted(foo_tab_id); 193
194 // HasDataUseTrackingStarted should return true only once.
195 data_use_tab_model()->NotifyObserversOfTrackingStarting(foo_tab_id);
53 EXPECT_TRUE(data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id)); 196 EXPECT_TRUE(data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id));
54 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id)); 197 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id));
55 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingEnded(foo_tab_id)); 198 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingEnded(foo_tab_id));
56 199
57 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(bar_tab_id)); 200 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(bar_tab_id));
58 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingEnded(bar_tab_id)); 201 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingEnded(bar_tab_id));
59 202
60 // ShowExit should return true only once. 203 // HasDataUseTrackingEnded should return true only once.
61 data_use_ui_tab_model()->OnTrackingEnded(foo_tab_id); 204 data_use_tab_model()->NotifyObserversOfTrackingEnding(foo_tab_id);
62 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id)); 205 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id));
63 EXPECT_TRUE(data_use_ui_tab_model()->HasDataUseTrackingEnded(foo_tab_id)); 206 EXPECT_TRUE(data_use_ui_tab_model()->HasDataUseTrackingEnded(foo_tab_id));
64 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingEnded(foo_tab_id)); 207 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingEnded(foo_tab_id));
65 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id)); 208 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id));
66 209
67 // The tab enters the tracking state again. 210 // The tab enters the tracking state again.
68 data_use_ui_tab_model()->OnTrackingStarted(foo_tab_id); 211 data_use_tab_model()->NotifyObserversOfTrackingStarting(foo_tab_id);
69 EXPECT_TRUE(data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id)); 212 EXPECT_TRUE(data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id));
70 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id)); 213 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id));
71 214
72 // The tab exits the tracking state. 215 // The tab exits the tracking state.
73 data_use_ui_tab_model()->OnTrackingEnded(foo_tab_id); 216 data_use_tab_model()->NotifyObserversOfTrackingEnding(foo_tab_id);
74 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id)); 217 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id));
75 218
76 // The tab enters the tracking state again. 219 // The tab enters the tracking state again.
77 data_use_ui_tab_model()->OnTrackingStarted(foo_tab_id); 220 data_use_tab_model()->NotifyObserversOfTrackingStarting(foo_tab_id);
78 data_use_ui_tab_model()->OnTrackingStarted(foo_tab_id); 221 data_use_tab_model()->NotifyObserversOfTrackingStarting(foo_tab_id);
79 EXPECT_TRUE(data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id)); 222 EXPECT_TRUE(data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id));
80 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id)); 223 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(foo_tab_id));
81 224
82 // ShowExit should return true only once. 225 // ShowExit should return true only once.
83 data_use_ui_tab_model()->OnTrackingEnded(bar_tab_id); 226 data_use_tab_model()->NotifyObserversOfTrackingEnding(bar_tab_id);
84 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(bar_tab_id)); 227 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(bar_tab_id));
85 EXPECT_TRUE(data_use_ui_tab_model()->HasDataUseTrackingEnded(bar_tab_id)); 228 EXPECT_TRUE(data_use_ui_tab_model()->HasDataUseTrackingEnded(bar_tab_id));
86 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingEnded(bar_tab_id)); 229 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingEnded(bar_tab_id));
87 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(bar_tab_id)); 230 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(bar_tab_id));
88 231
89 data_use_ui_tab_model()->ReportTabClosure(foo_tab_id); 232 data_use_ui_tab_model()->ReportTabClosure(foo_tab_id);
90 data_use_ui_tab_model()->ReportTabClosure(bar_tab_id); 233 data_use_ui_tab_model()->ReportTabClosure(bar_tab_id);
91 234
92 // HasDataUseTrackingStarted/Ended should return false for closed tabs. 235 // HasDataUseTrackingStarted/Ended should return false for closed tabs.
93 data_use_ui_tab_model()->OnTrackingStarted(baz_tab_id); 236 data_use_tab_model()->NotifyObserversOfTrackingStarting(baz_tab_id);
94 data_use_ui_tab_model()->ReportTabClosure(baz_tab_id); 237 data_use_ui_tab_model()->ReportTabClosure(baz_tab_id);
95 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(baz_tab_id)); 238 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(baz_tab_id));
96 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingEnded(baz_tab_id)); 239 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingEnded(baz_tab_id));
97 } 240 }
98 241
242 // Checks if page transition type is converted correctly.
243 TEST_F(DataUseUITabModelTest, ConvertTransitionType) {
244 DataUseTabModel::TransitionType transition_type;
245 EXPECT_TRUE(data_use_ui_tab_model()->ConvertTransitionType(
246 ui::PageTransition(ui::PAGE_TRANSITION_TYPED), &transition_type));
247 EXPECT_EQ(DataUseTabModel::TRANSITION_OMNIBOX_NAVIGATION, transition_type);
248 EXPECT_TRUE(data_use_ui_tab_model()->ConvertTransitionType(
249 ui::PageTransition(ui::PAGE_TRANSITION_TYPED | 0xFF00),
250 &transition_type));
251 EXPECT_EQ(DataUseTabModel::TRANSITION_OMNIBOX_NAVIGATION, transition_type);
252 EXPECT_TRUE(data_use_ui_tab_model()->ConvertTransitionType(
253 ui::PageTransition(ui::PAGE_TRANSITION_TYPED | 0xFFFF00),
254 &transition_type));
255 EXPECT_EQ(DataUseTabModel::TRANSITION_OMNIBOX_NAVIGATION, transition_type);
256 EXPECT_TRUE(data_use_ui_tab_model()->ConvertTransitionType(
257 ui::PageTransition(ui::PAGE_TRANSITION_TYPED | 0x12FFFF00),
258 &transition_type));
259 EXPECT_EQ(DataUseTabModel::TRANSITION_OMNIBOX_NAVIGATION, transition_type);
260
261 EXPECT_TRUE(data_use_ui_tab_model()->ConvertTransitionType(
262 ui::PageTransition(ui::PAGE_TRANSITION_AUTO_BOOKMARK), &transition_type));
263 EXPECT_EQ(DataUseTabModel::TRANSITION_BOOKMARK, transition_type);
264 EXPECT_TRUE(data_use_ui_tab_model()->ConvertTransitionType(
265 ui::PageTransition(ui::PAGE_TRANSITION_AUTO_BOOKMARK | 0xFF00),
266 &transition_type));
267 EXPECT_EQ(DataUseTabModel::TRANSITION_BOOKMARK, transition_type);
268 EXPECT_TRUE(data_use_ui_tab_model()->ConvertTransitionType(
269 ui::PageTransition(ui::PAGE_TRANSITION_AUTO_BOOKMARK | 0xFFFF00),
270 &transition_type));
271 EXPECT_EQ(DataUseTabModel::TRANSITION_BOOKMARK, transition_type);
272 EXPECT_TRUE(data_use_ui_tab_model()->ConvertTransitionType(
273 ui::PageTransition(ui::PAGE_TRANSITION_AUTO_BOOKMARK | 0x12FFFF00),
274 &transition_type));
275 EXPECT_EQ(DataUseTabModel::TRANSITION_BOOKMARK, transition_type);
276
277 EXPECT_TRUE(data_use_ui_tab_model()->ConvertTransitionType(
278 ui::PageTransition(ui::PAGE_TRANSITION_GENERATED), &transition_type));
279 EXPECT_EQ(DataUseTabModel::TRANSITION_OMNIBOX_SEARCH, transition_type);
280 EXPECT_TRUE(data_use_ui_tab_model()->ConvertTransitionType(
281 ui::PageTransition(ui::PAGE_TRANSITION_GENERATED | 0xFF00),
282 &transition_type));
283 EXPECT_EQ(DataUseTabModel::TRANSITION_OMNIBOX_SEARCH, transition_type);
284 EXPECT_TRUE(data_use_ui_tab_model()->ConvertTransitionType(
285 ui::PageTransition(ui::PAGE_TRANSITION_GENERATED | 0xFFFF00),
286 &transition_type));
287 EXPECT_EQ(DataUseTabModel::TRANSITION_OMNIBOX_SEARCH, transition_type);
288 EXPECT_TRUE(data_use_ui_tab_model()->ConvertTransitionType(
289 ui::PageTransition(ui::PAGE_TRANSITION_GENERATED | 0x12FFFF00),
290 &transition_type));
291 EXPECT_EQ(DataUseTabModel::TRANSITION_OMNIBOX_SEARCH, transition_type);
292
293 EXPECT_FALSE(data_use_ui_tab_model()->ConvertTransitionType(
294 ui::PageTransition(ui::PAGE_TRANSITION_AUTO_SUBFRAME), &transition_type));
295 EXPECT_FALSE(data_use_ui_tab_model()->ConvertTransitionType(
296 ui::PageTransition(ui::PAGE_TRANSITION_MANUAL_SUBFRAME),
297 &transition_type));
298 EXPECT_FALSE(data_use_ui_tab_model()->ConvertTransitionType(
299 ui::PageTransition(ui::PAGE_TRANSITION_FORM_SUBMIT), &transition_type));
300 }
301
99 } // namespace android 302 } // namespace android
100 303
101 } // namespace chrome 304 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698