Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1443653002: Documentation: Further cleanup (Closed)

Created:
5 years, 1 month ago by hal.canary
Modified:
5 years, 1 month ago
Reviewers:
hcm
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Documentation: Further cleanup * /user/download: remove instruction to compile and run skia tests - moved to /user/quick/${OS} * /user/quick/desktop: move Gyp options to a section in the FAQ (distracts from quick start narritive). * /user/tips: reformat, rewrite. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1443653002 Committed: https://skia.googlesource.com/skia/+/b5002394d141c4adbf4d7c5e39c1d23363f501e3

Patch Set 1 #

Patch Set 2 : 2015-11-13 (Friday) 09:05:37 EST #

Patch Set 3 : 2015-11-13 (Friday) 09:16:29 EST #

Patch Set 4 : 2015-11-13 (Friday) 09:17:16 EST #

Patch Set 5 : 2015-11-13 (Friday) 09:22:45 EST #

Patch Set 6 : 2015-11-16 (Monday) 10:21:07 EST #

Total comments: 4

Patch Set 7 : 2015-11-16 (Monday) 10:36:02 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -92 lines) Patch
M site/user/download.md View 1 2 3 4 5 6 1 chunk +7 lines, -29 lines 0 comments Download
M site/user/quick/desktop.md View 1 2 1 chunk +3 lines, -44 lines 0 comments Download
M site/user/tips.md View 1 2 3 4 3 chunks +69 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
hal.canary
5 years, 1 month ago (2015-11-16 15:24:48 UTC) #3
hcm
lgtm with two minor adjustments https://codereview.chromium.org/1443653002/diff/100001/site/user/download.md File site/user/download.md (right): https://codereview.chromium.org/1443653002/diff/100001/site/user/download.md#newcode31 site/user/download.md:31: [Android](./quick/android)-, and [iOS](./quick/ios)-specific Skia ...
5 years, 1 month ago (2015-11-16 15:32:11 UTC) #4
hal.canary
https://codereview.chromium.org/1443653002/diff/100001/site/user/download.md File site/user/download.md (right): https://codereview.chromium.org/1443653002/diff/100001/site/user/download.md#newcode31 site/user/download.md:31: [Android](./quick/android)-, and [iOS](./quick/ios)-specific Skia On 2015/11/16 at 15:32:10, hcm ...
5 years, 1 month ago (2015-11-16 15:36:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443653002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443653002/120001
5 years, 1 month ago (2015-11-16 15:36:42 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 15:37:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/b5002394d141c4adbf4d7c5e39c1d23363f501e3

Powered by Google App Engine
This is Rietveld 408576698