Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 144363008: Add support for schema validate error to PolicyErrorMap (Closed)

Created:
6 years, 10 months ago by binjin
Modified:
6 years, 10 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@expand-policy-schema-3.5
Visibility:
Public.

Description

Add support for schema validate error to PolicyErrorMap BUG=258339 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249005

Patch Set 1 #

Patch Set 2 : rebase; fix ios build #

Total comments: 8

Patch Set 3 : fixes #

Total comments: 2

Patch Set 4 : fix indention #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -63 lines) Patch
M build/ios/grit_whitelist.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/policy/core/browser/policy_error_map.h View 4 chunks +12 lines, -5 lines 0 comments Download
M components/policy/core/browser/policy_error_map.cc View 1 2 3 3 chunks +127 lines, -58 lines 0 comments Download
M components/policy_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
binjin
Hello Joao, PTAL at this CL, thanks. Bin
6 years, 10 months ago (2014-01-28 16:28:04 UTC) #1
Joao da Silva
Looks good https://codereview.chromium.org/144363008/diff/20001/components/policy/core/browser/policy_error_map.cc File components/policy/core/browser/policy_error_map.cc (right): https://codereview.chromium.org/144363008/diff/20001/components/policy/core/browser/policy_error_map.cc#newcode20 components/policy/core/browser/policy_error_map.cc:20: PendingError(const std::string& policy_name) : policy_name_(policy_name) {} explicit ...
6 years, 10 months ago (2014-01-29 09:14:41 UTC) #2
binjin
Hello Joao, PTAL at the newest patchset. I also renamed SchemaValidatePendingError to be compatible to ...
6 years, 10 months ago (2014-02-03 14:40:18 UTC) #3
Joao da Silva
lgtm https://codereview.chromium.org/144363008/diff/40001/components/policy/core/browser/policy_error_map.cc File components/policy/core/browser/policy_error_map.cc (right): https://codereview.chromium.org/144363008/diff/40001/components/policy/core/browser/policy_error_map.cc#newcode111 components/policy/core/browser/policy_error_map.cc:111: const std::string& replacement) nit: fix the indentation of ...
6 years, 10 months ago (2014-02-05 09:21:18 UTC) #4
binjin
https://codereview.chromium.org/144363008/diff/40001/components/policy/core/browser/policy_error_map.cc File components/policy/core/browser/policy_error_map.cc (right): https://codereview.chromium.org/144363008/diff/40001/components/policy/core/browser/policy_error_map.cc#newcode111 components/policy/core/browser/policy_error_map.cc:111: const std::string& replacement) On 2014/02/05 09:21:18, Joao da Silva ...
6 years, 10 months ago (2014-02-05 10:01:45 UTC) #5
binjin
The CQ bit was checked by binjin@chromium.org
6 years, 10 months ago (2014-02-05 10:01:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binjin@chromium.org/144363008/160001
6 years, 10 months ago (2014-02-05 10:08:38 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 11:19:42 UTC) #8
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=45084
6 years, 10 months ago (2014-02-05 11:19:42 UTC) #9
binjin
The CQ bit was checked by binjin@chromium.org
6 years, 10 months ago (2014-02-05 12:03:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binjin@chromium.org/144363008/160001
6 years, 10 months ago (2014-02-05 12:06:31 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 13:01:42 UTC) #12
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=45123
6 years, 10 months ago (2014-02-05 13:01:43 UTC) #13
binjin
The CQ bit was checked by binjin@chromium.org
6 years, 10 months ago (2014-02-05 13:43:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binjin@chromium.org/144363008/160001
6 years, 10 months ago (2014-02-05 13:43:35 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 15:32:13 UTC) #16
Message was sent while issue was closed. 
Change committed as 249005

Powered by Google App Engine
This is Rietveld 408576698