Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2974)

Unified Diff: chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h

Issue 144363006: Expand VPD initial_locale to a list of locales. Use the expanded VPD initial_locale on the OOBE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Implement options group in language select. Fix unittest. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h
diff --git a/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h b/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h
index 32bf026b16a7813b834a4d6357f6277148c1ce0d..6ddd2f3ff868ec7614703cc74af026fc95a4e0d1 100644
--- a/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h
+++ b/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h
@@ -46,6 +46,8 @@ class CrosLanguageOptionsHandler
// The return value will look like:
// [{'code': 'fi', 'displayName': 'Finnish', 'nativeDisplayName': 'suomi'},
// ...]
+ // "most relevant" languages, as set in initial_locale in VPD, will be first
+ // in the list.
static base::ListValue* GetAcceptLanguageList(
const input_method::InputMethodDescriptors& descriptors);
@@ -53,6 +55,10 @@ class CrosLanguageOptionsHandler
// The return value will look like:
// [{'code': 'fi', 'displayName': 'Finnish', 'nativeDisplayName': 'suomi'},
// ...]
+ // "most relevant" languages, as set in initial_locale in VPD, will be first
+ // in the list.
+ // An entry with empty "code" is used as a divider to separate "most
+ // relevant" languages against other.
static base::ListValue* GetUILanguageList(
const input_method::InputMethodDescriptors& descriptors);
@@ -88,9 +94,12 @@ class CrosLanguageOptionsHandler
// Gets the list of languages with |descriptors| based on
// |base_language_codes|.
+ // |insert_divider| means to insert empty string between "most relevant"
+ // languages and other.
static base::ListValue* GetLanguageListInternal(
const input_method::InputMethodDescriptors& descriptors,
- const std::vector<std::string>& base_language_codes);
+ const std::vector<std::string>& base_language_codes,
+ const bool insert_divider);
Dmitry Polukhin 2014/01/28 19:40:30 nit, const here has no sense and we usually omit i
Alexander Alekseev 2014/01/29 15:39:00 Done.
// OptionsPageUIHandler implementation.
virtual void InitializePage() OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698