[rac] Use stale libaddressinput data if download fails

third_party/libaddressinput/chromium/cpp/src/retriever.cc

 // Copyright (C) 2013 Google Inc.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 // http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "retriever.h"
 
 #include <libaddressinput/callback.h>
 #include <libaddressinput/downloader.h>
 #include <libaddressinput/storage.h>
 #include <libaddressinput/util/basictypes.h>
 #include <libaddressinput/util/scoped_ptr.h>
 
 #include <cassert>
 #include <cstddef>
+#include <ctime>
 #include <map>
 #include <string>
 #include <utility>
 
 #include "fallback_data_store.h"
 #include "util/stl_util.h"
+#include "validating_util.h"
 
 namespace i18n {
 namespace addressinput {
 
 Retriever::Retriever(const std::string& validation_data_url,
                      scoped_ptr<Downloader> downloader,
                      scoped_ptr<Storage> storage)
     : validation_data_url_(validation_data_url),
       downloader_(downloader.Pass()),
-      storage_(storage.Pass()) {
+      storage_(storage.Pass()),
+      stale_data_() {
   assert(validation_data_url_.length() > 0);
   assert(validation_data_url_[validation_data_url_.length() - 1] == '/');
   assert(storage_ != NULL);
   assert(downloader_ != NULL);
 }
 
 Retriever::~Retriever() {
   STLDeleteValues(&requests_);
 }
 
 void Retriever::Retrieve(const std::string& key,
                          scoped_ptr<Callback> retrieved) {
   std::map<std::string, Callback*>::iterator request_it =
       requests_.find(key);
   if (request_it != requests_.end()) {
     // Abandon a previous request.
     delete request_it->second;
     requests_.erase(request_it);
   }
 
   requests_[key] = retrieved.release();
   storage_->Get(key,
                 BuildCallback(this, &Retriever::OnDataRetrievedFromStorage));
 }
 
 void Retriever::OnDataRetrievedFromStorage(bool success,
                                            const std::string& key,
                                            const std::string& stored_data) {
-  // TODO(rouslan): Add validation for data integrity and freshness. If a
-  // download fails, then it's OK to use stale data.
-  if (success) {
+  std::string unwrapped = stored_data;
+  ValidatingUtil::TimestampStatus timestamp_status =
+      ValidatingUtil::UnwrapTimestamp(&unwrapped, time(NULL));
+  bool checksum_valid = ValidatingUtil::UnwrapChecksum(&unwrapped);
+
+  if (success &&
+      timestamp_status == ValidatingUtil::TIMESTAMP_VALID &&
+      checksum_valid) {
     scoped_ptr<Callback> retrieved = GetCallbackForKey(key);
     if (retrieved != NULL) {
-      (*retrieved)(success, key, stored_data);
+      (*retrieved)(success, key, unwrapped);
     }
   } else {
+    if (success &&
+        timestamp_status == ValidatingUtil::TIMESTAMP_STALE &&
+        checksum_valid) {
+      stale_data_[key] = unwrapped;
+    }
     downloader_->Download(GetUrlForKey(key),
                           BuildCallback(this, &Retriever::OnDownloaded));
   }
 }
 
 void Retriever::OnDownloaded(bool success,
                              const std::string& url,
                              const std::string& downloaded_data) {
   const std::string& key = GetKeyForUrl(url);
   std::string response;
+  std::map<std::string, std::string>::iterator stale_data_it =
+      stale_data_.find(key);
+
   if (success) {
-    storage_->Put(key, downloaded_data);
+    storage_->Put(key, ValidatingUtil::Wrap(downloaded_data, time(NULL)));
     response = downloaded_data;
+  } else if (stale_data_it != stale_data_.end()) {
+    success = true;
+    response = stale_data_it->second;
   } else {
-    success = FallbackDataStore::Get(key, &response);
+      success = FallbackDataStore::Get(key, &response);
+  }
+
+  if (stale_data_it != stale_data_.end()) {
+    stale_data_.erase(stale_data_it);
   }
 
   scoped_ptr<Callback> retrieved = GetCallbackForKey(key);
   if (retrieved != NULL) {
     (*retrieved)(success, key, response);
   }
 }
 
 std::string Retriever::GetUrlForKey(const std::string& key) const {
   return validation_data_url_ + key;
@@ skipping 19 matching lines @@
     // An abandonened request.
     return scoped_ptr<Callback>();
   }
   scoped_ptr<Callback> callback(iter->second);
   requests_.erase(iter);
   return callback.Pass();
 }
 
 }  // namespace addressinput
 }  // namespace i18n