Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1443463002: Enforce "set noparent" on metrics XML files. (Closed)

Created:
5 years, 1 month ago by Alexei Svitkine (slow)
Modified:
5 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enforce "set noparent" on metrics XML files. This restores this enforcement that was recently removed from tools/metrics by: https://codereview.chromium.org/1437683006/ See discussion on that CL for more context. Also, removes jar@ from tools/metrics/OWNERS as he no longer actively does metrics reviews in Chromium. BUG=none Committed: https://crrev.com/b2ced0815d5e9e2d3265ff116d45719261906c4e Cr-Commit-Position: refs/heads/master@{#359625}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M tools/metrics/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
A + tools/metrics/actions/OWNERS View 1 chunk +3 lines, -1 line 0 comments Download
A + tools/metrics/histograms/OWNERS View 1 chunk +3 lines, -1 line 0 comments Download
M tools/metrics/rappor/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Alexei Svitkine (slow)
5 years, 1 month ago (2015-11-12 22:58:14 UTC) #3
Ilya Sherman
LGTM, thanks. Have you checked to make sure that this syntax works as expected?
5 years, 1 month ago (2015-11-13 00:57:19 UTC) #4
Alexei Svitkine (slow)
Any ideas of how to test it before landing? In terms of syntax, I copied ...
5 years, 1 month ago (2015-11-13 15:42:24 UTC) #5
Ilya Sherman
On 2015/11/13 15:42:24, Alexei Svitkine (slow) wrote: > Any ideas of how to test it ...
5 years, 1 month ago (2015-11-13 20:06:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443463002/20001
5 years, 1 month ago (2015-11-13 20:21:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 1 month ago (2015-11-13 20:42:36 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b2ced0815d5e9e2d3265ff116d45719261906c4e Cr-Commit-Position: refs/heads/master@{#359625}
5 years, 1 month ago (2015-11-13 20:43:52 UTC) #10
Alexei Svitkine (slow)
5 years, 1 month ago (2015-11-13 21:23:51 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/1448523002/ by asvitkine@chromium.org.

The reason for reverting is: I think this broke owners checks for metrics xml
files..

Powered by Google App Engine
This is Rietveld 408576698