Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1443433002: Dart: Use dart:developer for tracing in startup benchmark. (Closed)

Created:
5 years, 1 month ago by zra
Modified:
5 years, 1 month ago
Reviewers:
Cutch
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix analyzer warnings #

Patch Set 3 : Roll binary sdk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -20 lines) Patch
M benchmarks/dart_handler_running/lib/main.dart View 1 1 chunk +2 lines, -6 lines 0 comments Download
M benchmarks/dart_startup/lib/main.dart View 1 1 chunk +3 lines, -10 lines 0 comments Download
M mojo/tools/data/benchmarks View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/dart/update.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
zra
This saves another ~10+ ms. John, it would be nice to be able to specify ...
5 years, 1 month ago (2015-11-12 22:39:01 UTC) #2
zra
Hmm. It looks like the analyzer doesn't believe that Timeline.instantSync exists. Any ideas?
5 years, 1 month ago (2015-11-12 23:02:42 UTC) #3
Cutch
On 2015/11/12 23:02:42, zra wrote: > Hmm. It looks like the analyzer doesn't believe that ...
5 years, 1 month ago (2015-11-12 23:03:47 UTC) #4
zra
On 2015/11/12 23:03:47, Cutch wrote: > Roll the binary sdk forward Ah, right. The most ...
5 years, 1 month ago (2015-11-12 23:13:37 UTC) #5
zra
PTAL. Will switch RTT benchmark to dart:tracing in another CL since it looks like I'll ...
5 years, 1 month ago (2015-11-19 17:40:15 UTC) #6
Cutch
lgtm
5 years, 1 month ago (2015-11-19 17:55:42 UTC) #7
zra
5 years, 1 month ago (2015-11-19 17:57:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
653331f1044ffe38a010e6bc33450fbdc9794cc5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698