Issue 144343005: Clean up BrowserWindowController by using the ObjCCast helper function.

Issue 144343005: Clean up BrowserWindowController by using the ObjCCast helper function. (Closed)

Created:
6 years, 11 months ago by Avi (use Gerrit)

Modified:
6 years, 10 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Clean up BrowserWindowController by using the ObjCCast helper function. BUG=none TEST=no change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247553

Patch Set 2 : rename #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -28 lines)			Patch
	M	chrome/browser/ui/cocoa/browser_window_controller.mm	View	1	7 chunks	+25 lines, -28 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

Minor cleanup before I go in there with a machete.

6 years, 11 months ago (2014-01-28 00:34:30 UTC) #1

Robert Sesek

LGTM https://codereview.chromium.org/144343005/diff/1/chrome/browser/ui/cocoa/browser_window_controller.mm File chrome/browser/ui/cocoa/browser_window_controller.mm (right): https://codereview.chromium.org/144343005/diff/1/chrome/browser/ui/cocoa/browser_window_controller.mm#newcode1823 chrome/browser/ui/cocoa/browser_window_controller.mm:1823: if (SadTabController* sad_tab = naming: sadTab and webContents ...

6 years, 10 months ago (2014-01-28 14:36:51 UTC) #2

Avi (use Gerrit)

https://codereview.chromium.org/144343005/diff/1/chrome/browser/ui/cocoa/browser_window_controller.mm File chrome/browser/ui/cocoa/browser_window_controller.mm (right): https://codereview.chromium.org/144343005/diff/1/chrome/browser/ui/cocoa/browser_window_controller.mm#newcode1823 chrome/browser/ui/cocoa/browser_window_controller.mm:1823: if (SadTabController* sad_tab = On 2014/01/28 14:36:51, rsesek wrote: ...

6 years, 10 months ago (2014-01-28 15:48:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/144343005/20001

6 years, 10 months ago (2014-01-28 18:23:56 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=252904

6 years, 10 months ago (2014-01-28 21:04:01 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/144343005/20001

6 years, 10 months ago (2014-01-28 21:15:27 UTC) #6

Message was sent while issue was closed.

Change committed as 247553

Expand Messages | Collapse Messages