Add --skip_cpu and --skip_gpu options to tests

tests/skia_test.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "OverwriteLine.h"
 #include "SkCommandLineFlags.h"
 #include "SkGraphics.h"
@@ skipping 17 matching lines @@
                                "$ requires the end of the test to match\n" \
                                "^ and $ requires an exact match\n" \
                                "If a test does not match any list entry,\n" \
                                "it is skipped unless some list entry starts with ~");
 DEFINE_string2(tmpDir, t, NULL, "tmp directory for tests to use.");
 DEFINE_string2(resourcePath, i, "resources", "directory for test resources.");
 DEFINE_bool2(extendedTest, x, false, "run extended tests for pathOps.");
 DEFINE_bool2(leaks, l, false, "show leaked ref cnt'd objects.");
 DEFINE_bool2(single, z, false, "run tests on a single thread internally.");
 DEFINE_bool2(verbose, v, false, "enable verbose output.");
+DEFINE_bool(skip_cpu, false, "skip CPU tests.");

[mtklein, 2014/01/27 22:35:29]

Would somewhat prefer to keep the flags positively oriented:

DEFINE_bool(cpu, true, "Run CPU tests.");
DEFINE_bool(gpu, true, "Run GPU tests.");

You get the negation for free from the flags: --nocpu, --nogpu

(Or run_cpu/run_gpu.  I just like it positive.)

[djsollen, 2014/01/28 14:21:02]

I'm a fan of this as well.

On 2014/01/27 22:35:29, mtklein wrote:

[borenet, 2014/01/28 18:42:09]

Done.

+DEFINE_bool(skip_gpu, false, "skip GPU tests.");
 DEFINE_int32(threads, SkThreadPool::kThreadPerCore,
              "Run threadsafe tests on a threadpool with this many threads.");
 
 // need to explicitly declare this, or we get some weird infinite loop llist
 template TestRegistry* TestRegistry::gHead;
 
 class Iter {
 public:
     Iter() { this->reset(); }
     void reset() { fReg = TestRegistry::Head(); }
@@ skipping 119 matching lines @@
     int total = 0;
     int toRun = 0;
     Test* test;
 
     Iter iter;
     while ((test = iter.next(NULL/*reporter not needed*/)) != NULL) {
         SkAutoTDelete<Test> owned(test);
 
         if(!SkCommandLineFlags::ShouldSkip(FLAGS_match, test->getName())) {
             toRun++;
+        } else if (test->isGPUTest() && !FLAGS_skip_gpu){

[mtklein, 2014/01/27 22:35:29]

I think this is going to double-count?

Shouldn't it be

if (!ShouldSkip) {
  if ( test->isGPUTest() && !FLAGS_skip_gpu) toRun++;
  if (!test->isGPUTest() && !FLAGS_skip_cpu) toRun++;
}
?

[borenet, 2014/01/28 18:42:09]

Moved to its own function for clarity.

+            toRun++;
+        } else if (!test->isGPUTest() && !FLAGS_skip_cpu) {
+            toRun++;
         }
         total++;
     }
 
     // Now run them.
     iter.reset();
     int32_t failCount = 0;
     int skipCount = 0;
 
     SkThreadPool threadpool(FLAGS_threads);
     SkTArray<Test*> unsafeTests;  // Always passes ownership to an SkTestRunnable
 
     DebugfReporter reporter(toRun);
     for (int i = 0; i < total; i++) {
         SkAutoTDelete<Test> test(iter.next(&reporter));
         if (SkCommandLineFlags::ShouldSkip(FLAGS_match, test->getName())) {
             ++skipCount;
+        } else if (test->isGPUTest() && FLAGS_skip_gpu) {

[mtklein, 2014/01/27 22:35:29]

Same deal down here.

+            ++skipCount;
+        } else if (!test->isGPUTest() && FLAGS_skip_cpu) {
+            ++skipCount;
         } else if (!test->isThreadsafe()) {
             unsafeTests.push_back() = test.detach();
         } else {
             threadpool.add(SkNEW_ARGS(SkTestRunnable, (test.detach(), &failCount)));
         }
     }
 
     // Run the tests that aren't threadsafe.
     for (int i = 0; i < unsafeTests.count(); i++) {
         SkNEW_ARGS(SkTestRunnable, (unsafeTests[i], &failCount))->run();
@@ skipping 11 matching lines @@
 
     SkDebugf("\n");
     return (failCount == 0) ? 0 : 1;
 }
 
 #if !defined(SK_BUILD_FOR_IOS) && !defined(SK_BUILD_FOR_NACL)
 int main(int argc, char * const argv[]) {
     return tool_main(argc, (char**) argv);
 }
 #endif