Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 144343002: Rename kDummyTokenIndex to kNoSourcePos (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 1394 matching lines...) Expand 10 before | Expand all | Expand 10 after
1405 } 1405 }
1406 1406
1407 if (needs_number_check) { 1407 if (needs_number_check) {
1408 __ pushl(reg); 1408 __ pushl(reg);
1409 __ PushObject(obj); 1409 __ PushObject(obj);
1410 if (is_optimizing()) { 1410 if (is_optimizing()) {
1411 __ call(&StubCode::OptimizedIdenticalWithNumberCheckLabel()); 1411 __ call(&StubCode::OptimizedIdenticalWithNumberCheckLabel());
1412 } else { 1412 } else {
1413 __ call(&StubCode::UnoptimizedIdenticalWithNumberCheckLabel()); 1413 __ call(&StubCode::UnoptimizedIdenticalWithNumberCheckLabel());
1414 } 1414 }
1415 if (token_pos != Scanner::kDummyTokenIndex) { 1415 if (token_pos != Scanner::kNoSourcePos) {
1416 AddCurrentDescriptor(PcDescriptors::kRuntimeCall, 1416 AddCurrentDescriptor(PcDescriptors::kRuntimeCall,
1417 Isolate::kNoDeoptId, 1417 Isolate::kNoDeoptId,
1418 token_pos); 1418 token_pos);
1419 } 1419 }
1420 __ popl(reg); // Discard constant. 1420 __ popl(reg); // Discard constant.
1421 __ popl(reg); // Restore 'reg'. 1421 __ popl(reg); // Restore 'reg'.
1422 return; 1422 return;
1423 } 1423 }
1424 1424
1425 __ CompareObject(reg, obj); 1425 __ CompareObject(reg, obj);
1426 } 1426 }
1427 1427
1428 1428
1429 void FlowGraphCompiler::EmitEqualityRegRegCompare(Register left, 1429 void FlowGraphCompiler::EmitEqualityRegRegCompare(Register left,
1430 Register right, 1430 Register right,
1431 bool needs_number_check, 1431 bool needs_number_check,
1432 intptr_t token_pos) { 1432 intptr_t token_pos) {
1433 if (needs_number_check) { 1433 if (needs_number_check) {
1434 __ pushl(left); 1434 __ pushl(left);
1435 __ pushl(right); 1435 __ pushl(right);
1436 if (is_optimizing()) { 1436 if (is_optimizing()) {
1437 __ call(&StubCode::OptimizedIdenticalWithNumberCheckLabel()); 1437 __ call(&StubCode::OptimizedIdenticalWithNumberCheckLabel());
1438 } else { 1438 } else {
1439 __ call(&StubCode::UnoptimizedIdenticalWithNumberCheckLabel()); 1439 __ call(&StubCode::UnoptimizedIdenticalWithNumberCheckLabel());
1440 } 1440 }
1441 if (token_pos != Scanner::kDummyTokenIndex) { 1441 if (token_pos != Scanner::kNoSourcePos) {
1442 AddCurrentDescriptor(PcDescriptors::kRuntimeCall, 1442 AddCurrentDescriptor(PcDescriptors::kRuntimeCall,
1443 Isolate::kNoDeoptId, 1443 Isolate::kNoDeoptId,
1444 token_pos); 1444 token_pos);
1445 } 1445 }
1446 // Stub returns result in flags (result of a cmpl, we need ZF computed). 1446 // Stub returns result in flags (result of a cmpl, we need ZF computed).
1447 __ popl(right); 1447 __ popl(right);
1448 __ popl(left); 1448 __ popl(left);
1449 } else { 1449 } else {
1450 __ cmpl(left, right); 1450 __ cmpl(left, right);
1451 } 1451 }
(...skipping 380 matching lines...) Expand 10 before | Expand all | Expand 10 after
1832 __ movups(reg, Address(ESP, 0)); 1832 __ movups(reg, Address(ESP, 0));
1833 __ addl(ESP, Immediate(kFpuRegisterSize)); 1833 __ addl(ESP, Immediate(kFpuRegisterSize));
1834 } 1834 }
1835 1835
1836 1836
1837 #undef __ 1837 #undef __
1838 1838
1839 } // namespace dart 1839 } // namespace dart
1840 1840
1841 #endif // defined TARGET_ARCH_IA32 1841 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698