Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: trunk/src/base/win/iat_patch_function.cc

Issue 144333003: Revert 246313 "Use an alternate mechanism for CreateFile calls i..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/build/common.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/base/win/iat_patch_function.cc
===================================================================
--- trunk/src/base/win/iat_patch_function.cc (revision 246540)
+++ trunk/src/base/win/iat_patch_function.cc (working copy)
@@ -56,23 +56,11 @@
}
// Change the page protection so that we can write.
- MEMORY_BASIC_INFORMATION memory_info;
DWORD error = NO_ERROR;
DWORD old_page_protection = 0;
-
- if (!::VirtualQuery(old_code, &memory_info, sizeof(memory_info))) {
- error = GetLastError();
- return error;
- }
-
- DWORD is_executable = (PAGE_EXECUTE | PAGE_EXECUTE_READ |
- PAGE_EXECUTE_READWRITE | PAGE_EXECUTE_WRITECOPY) &
- memory_info.Protect;
-
if (VirtualProtect(old_code,
length,
- is_executable ? PAGE_EXECUTE_READWRITE :
- PAGE_READWRITE,
+ PAGE_READWRITE,
&old_page_protection)) {
// Write the data.
@@ -86,6 +74,7 @@
&old_page_protection);
} else {
error = GetLastError();
+ NOTREACHED();
}
return error;
« no previous file with comments | « no previous file | trunk/src/build/common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698