Source/core/svg/animation/SVGSMILElement.cpp - Issue 144333002: Prevent crash in createInstanceTimesFromSyncbase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 144333002: Prevent crash in createInstanceTimesFromSyncbase (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/animation/SVGSMILElement.cpp

diff --git a/Source/core/svg/animation/SVGSMILElement.cpp b/Source/core/svg/animation/SVGSMILElement.cpp

index 1917ba57c72baf1c00b1fddbd0175f9c8b16fe24..cb08bd6bbbf467d531b0aa159e00a935a3284104 100644

--- a/Source/core/svg/animation/SVGSMILElement.cpp

+++ b/Source/core/svg/animation/SVGSMILElement.cpp

@@ -1245,7 +1245,8 @@ void SVGSMILElement::createInstanceTimesFromSyncbase(SVGSMILElement* syncbase)

time = syncbase->m_intervalBegin + condition.m_offset;

else

time = syncbase->m_intervalEnd + condition.m_offset;

- ASSERT(time.isFinite());

+ if (!time.isFinite())

+ continue;

if (condition.m_beginOrEnd == Begin)

addBeginTime(elapsed(), time);

else

« no previous file with comments | « LayoutTests/svg/animations/smil-syncbase-self-dependency-expected.txt ('k') | no next file » | no next file with comments »