Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 144313017: Make LeakSanitizer happy, part 2. Fixed register usage on the way. (Closed)

Created:
6 years, 10 months ago by Sven Panne
Modified:
6 years, 10 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Make LeakSanitizer happy, part 2. Fixed register usage on the way. Note that according to the System V ABI for AMD64, rbx must be preserved across calls. We actually crash with clang in the x64 assembler tests without that fix, we were lucky with GCC. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19178

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M test/cctest/test-assembler-x64.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-global-handles.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 10 months ago (2014-02-06 14:19:07 UTC) #1
Yang
On 2014/02/06 14:19:07, Sven Panne wrote: LGTM.
6 years, 10 months ago (2014-02-06 14:22:35 UTC) #2
Sven Panne
6 years, 10 months ago (2014-02-07 07:06:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19178 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698