Issue 144313014: Remove NodeList's anonymous named getter

Issue 144313014: Remove NodeList's anonymous named getter (Closed)

Created:
6 years, 10 months ago by Inactive

Modified:
6 years, 10 months ago

Reviewers:
tkent, haraken, arv (Not doing code reviews)

CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove NodeList's anonymous named getter Remove NodeList's anonymous named getter as this is not part of the specification: http://dom.spec.whatwg.org/#nodelist The new behavior is consistent with Firefox 26 and IE11. This was tested using: http://jsfiddle.net/HQ5Nf/3/ NodeList's named getter used to get needed when getElementsByClassName() / getElementsByTagName*() wrongly returned a NodeList instead of an HTMLCollection. However, this has been fixed in r166263. HTMLCollection does have an anonymous named getter. BUG=235008 R=arv, haraken, tkent Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166356

Patch Set 1 #

Patch Set 2 : clang build fix #

Patch Set 3 : Tiny idl fix #

Patch Set 4 : Another clang build fix #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -95 lines)			Patch
D	LayoutTests/fast/dom/childnode-item-after-itemname.html	View		1 chunk	+0 lines, -18 lines	0 comments	Download
D	LayoutTests/fast/dom/childnode-item-after-itemname-expected.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/dom/EmptyNodeList.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/LiveNodeList.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/LiveNodeList.cpp	View		1 chunk	+0 lines, -24 lines	0 comments	Download
M	Source/core/dom/NamedNodesCollection.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/NamedNodesCollection.cpp	View	1	1 chunk	+0 lines, -10 lines	0 comments	Download
M	Source/core/dom/NodeList.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/dom/NodeList.cpp	View		1 chunk	+0 lines, -18 lines	0 comments	Download
M	Source/core/dom/NodeList.idl	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/dom/StaticNodeList.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/StaticNodeList.cpp	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	Source/web/WebNodeList.cpp	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

LGTM Best patch I've seen this year.

6 years, 10 months ago (2014-02-03 22:29:55 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/144313014/100001

6 years, 10 months ago (2014-02-04 01:03:16 UTC) #5

Message was sent while issue was closed.

Change committed as 166356

Expand Messages | Collapse Messages