Supervised User whitelists: update to json format v2

Supervised User whitelists: update to json format v2

BUG=557635
Committed: https://crrev.com/d8a4b4663205374f77fac30e2bd07d247016fa9b
Cr-Commit-Position: refs/heads/master@{#360618}

[Marc Treib, 2015-11-18 11:27:42]

Description was changed from

==========
SupervisedUser whitelists: update to json format 2

BUG=
==========

to

==========
SupervisedUser whitelists: update to json format v2

BUG=557635
==========

[Marc Treib, 2015-11-18 11:39:26]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org

[Marc Treib, 2015-11-18 11:39:27]

bauerb: PTAL! (I'll add a component_updater owner later)

maybelle: FYI

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
File chrome/browser/supervised_user/supervised_user_url_filter.cc (right):

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_url_filter.cc:38:
base::hash_set<std::string> hostname_hashes;
I've simply removed the mapping for now. IMO no point in reimplementing it as
long as it isn't used anywhere. If we actually need it at some point, it'll be
straightforward enough to add.

[Bernhard Bauer, 2015-11-18 12:10:40]

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/componen...
File chrome/browser/component_updater/supervised_user_whitelist_installer.cc
(right):

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/componen...
chrome/browser/component_updater/supervised_user_whitelist_installer.cc:273:
base::Owned(manifest.release())));
base::Passed(&manifest)?

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/componen...
File chrome/browser/component_updater/supervised_user_whitelist_installer.h
(right):

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/componen...
chrome/browser/component_updater/supervised_user_whitelist_installer.h:14:
#include "base/strings/string16.h"
You can forward-declare string16.

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
File chrome/browser/supervised_user/supervised_user_site_list.cc (right):

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_site_list.cc:82: // Or just store
the raw bytes (from base::HexStringToBytes).
Would now be a good time to do this? 😃

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
File chrome/browser/supervised_user/supervised_user_url_filter.cc (right):

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_url_filter.cc:38:
base::hash_set<std::string> hostname_hashes;
On 2015/11/18 11:39:27, Marc Treib wrote:
> I've simply removed the mapping for now. IMO no point in reimplementing it as
> long as it isn't used anywhere. If we actually need it at some point, it'll be
> straightforward enough to add.

Hm. Can you add a TODO to add this back in for https://crbug.com/557651 then? 😃

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_url_filter.cc:113:
all_conditions_.push_back(condition_set);
std::move() the |condition_set|?

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_url_filter.cc:135:
scoped_ptr<SupervisedUserURLFilter::Contents> CreateWhitelistFromPatterns(
I think this should also have a ForTesting prefix.

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
File chrome/browser/supervised_user/supervised_user_whitelist_service.h (right):

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_whitelist_service.h:15: #include
"base/strings/string16.h"
Same here: you can forward-declare string16.

[Marc Treib, 2015-11-18 12:44:19]

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/componen...
File chrome/browser/component_updater/supervised_user_whitelist_installer.cc
(right):

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/componen...
chrome/browser/component_updater/supervised_user_whitelist_installer.cc:273:
base::Owned(manifest.release())));
On 2015/11/18 12:10:40, Bernhard Bauer wrote:
> base::Passed(&manifest)?

Done.

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/componen...
File chrome/browser/component_updater/supervised_user_whitelist_installer.h
(right):

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/componen...
chrome/browser/component_updater/supervised_user_whitelist_installer.h:14:
#include "base/strings/string16.h"
On 2015/11/18 12:10:40, Bernhard Bauer wrote:
> You can forward-declare string16.

Maybe I could, but I'd really rather not. Forward declarations for templates are
discouraged. Also on some platforms, string16 is a typedef for std::wstring, and
it's illegal to forward-declare stuff from std.

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
File chrome/browser/supervised_user/supervised_user_site_list.cc (right):

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_site_list.cc:82: // Or just store
the raw bytes (from base::HexStringToBytes).
On 2015/11/18 12:10:40, Bernhard Bauer wrote:
> Would now be a good time to do this? 😃

Hm. How about a follow-up CL, since it's really unrelated to the other changes
here, and will require touching a bunch of places?

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
File chrome/browser/supervised_user/supervised_user_url_filter.cc (right):

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_url_filter.cc:38:
base::hash_set<std::string> hostname_hashes;
On 2015/11/18 12:10:40, Bernhard Bauer wrote:
> On 2015/11/18 11:39:27, Marc Treib wrote:
> > I've simply removed the mapping for now. IMO no point in reimplementing it
as
> > long as it isn't used anywhere. If we actually need it at some point, it'll
be
> > straightforward enough to add.
> 
> Hm. Can you add a TODO to add this back in for https://crbug.com/557651 then?
😃

IMO it's not a TODO until we actually need it for some new feature, at which
point it'll just be part of that feature's implementation.

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_url_filter.cc:113:
all_conditions_.push_back(condition_set);
On 2015/11/18 12:10:40, Bernhard Bauer wrote:
> std::move() the |condition_set|?

Done. (This should save one refcount increment+decrement, right?)

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_url_filter.cc:135:
scoped_ptr<SupervisedUserURLFilter::Contents> CreateWhitelistFromPatterns(
On 2015/11/18 12:10:40, Bernhard Bauer wrote:
> I think this should also have a ForTesting prefix.

Done.

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
File chrome/browser/supervised_user/supervised_user_whitelist_service.h (right):

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_whitelist_service.h:15: #include
"base/strings/string16.h"
On 2015/11/18 12:10:40, Bernhard Bauer wrote:
> Same here: you can forward-declare string16.

Dito.

[Marc Treib, 2015-11-18 12:50:11]

Description was changed from

==========
SupervisedUser whitelists: update to json format v2

BUG=557635
==========

to

==========
Supervised User whitelists: update to json format v2

BUG=557635
==========

[Marc Treib, 2015-11-18 12:53:41]

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
File chrome/browser/supervised_user/supervised_user_url_filter.cc (right):

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_url_filter.cc:38:
base::hash_set<std::string> hostname_hashes;
On 2015/11/18 12:44:19, Marc Treib wrote:
> On 2015/11/18 12:10:40, Bernhard Bauer wrote:
> > On 2015/11/18 11:39:27, Marc Treib wrote:
> > > I've simply removed the mapping for now. IMO no point in reimplementing it
> as
> > > long as it isn't used anywhere. If we actually need it at some point,
it'll
> be
> > > straightforward enough to add.
> > 
> > Hm. Can you add a TODO to add this back in for https://crbug.com/557651
then?
> 😃
> 
> IMO it's not a TODO until we actually need it for some new feature, at which
> point it'll just be part of that feature's implementation.

Aah sorry, didn't realize this was a new bug specifically for this. Will do.

[Bernhard Bauer, 2015-11-18 13:10:12]

lgtm

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
File chrome/browser/supervised_user/supervised_user_url_filter.cc (right):

https://codereview.chromium.org/1443033004/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_url_filter.cc:113:
all_conditions_.push_back(condition_set);
On 2015/11/18 12:44:19, Marc Treib wrote:
> On 2015/11/18 12:10:40, Bernhard Bauer wrote:
> > std::move() the |condition_set|?
> 
> Done. (This should save one refcount increment+decrement, right?)

Correct.

[Marc Treib, 2015-11-18 13:19:21]

treib@chromium.org changed reviewers:
+ sorin@chromium.org

[Marc Treib, 2015-11-18 13:19:22]

+sorin for c/b/component_updater. PTAL!

[Sorin Jianu, 2015-11-18 16:18:54]

lgtm

Thank you Marc!

https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
File chrome/browser/supervised_user/supervised_user_site_list.cc (right):

https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_site_list.cc:57: GURL
entry_point,
ref to const?

https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
File chrome/browser/supervised_user/supervised_user_site_list.h (right):

https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_site_list.h:57: GURL entry_point,
Pass GURL parameter by reference to const?
Also, explicit is used for ctors with only one non-default params.

https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
File chrome/browser/supervised_user/supervised_user_url_filter.cc (right):

https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_url_filter.cc:57: std::string
hash = base::SHA1HashString(url.host());
const?

https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_url_filter.cc:115:
all_conditions_.push_back(std::move(condition_set));
What is the reason for calling std::move? It seems that it is a container of
scoped_refptrs.

[Marc Treib, 2015-11-18 16:33:37]

Thanks!

https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
File chrome/browser/supervised_user/supervised_user_site_list.cc (right):

https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_site_list.cc:57: GURL
entry_point,
On 2015/11/18 16:18:53, Sorin Jianu wrote:
> ref to const?

Done.

https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
File chrome/browser/supervised_user/supervised_user_site_list.h (right):

https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_site_list.h:57: GURL entry_point,
On 2015/11/18 16:18:53, Sorin Jianu wrote:
> Pass GURL parameter by reference to const?
> Also, explicit is used for ctors with only one non-default params.

Done.

https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
File chrome/browser/supervised_user/supervised_user_url_filter.cc (right):

https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_url_filter.cc:57: std::string
hash = base::SHA1HashString(url.host());
On 2015/11/18 16:18:54, Sorin Jianu wrote:
> const?

Done.

https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_url_filter.cc:115:
all_conditions_.push_back(std::move(condition_set));
On 2015/11/18 16:18:53, Sorin Jianu wrote:
> What is the reason for calling std::move? It seems that it is a container of
> scoped_refptrs.

condition_set is a scoped_refptr. Moving it instead of copying saves one
"roundtrip" of incrementing and decrementing the refcount.

[Sorin Jianu, 2015-11-18 16:51:04]

On 2015/11/18 16:33:37, Marc Treib wrote:
> Thanks!
> 
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> File chrome/browser/supervised_user/supervised_user_site_list.cc (right):
> 
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> chrome/browser/supervised_user/supervised_user_site_list.cc:57: GURL
> entry_point,
> On 2015/11/18 16:18:53, Sorin Jianu wrote:
> > ref to const?
> 
> Done.
> 
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> File chrome/browser/supervised_user/supervised_user_site_list.h (right):
> 
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> chrome/browser/supervised_user/supervised_user_site_list.h:57: GURL
entry_point,
> On 2015/11/18 16:18:53, Sorin Jianu wrote:
> > Pass GURL parameter by reference to const?
> > Also, explicit is used for ctors with only one non-default params.
> 
> Done.
> 
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> File chrome/browser/supervised_user/supervised_user_url_filter.cc (right):
> 
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> chrome/browser/supervised_user/supervised_user_url_filter.cc:57: std::string
> hash = base::SHA1HashString(url.host());
> On 2015/11/18 16:18:54, Sorin Jianu wrote:
> > const?
> 
> Done.
> 
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> chrome/browser/supervised_user/supervised_user_url_filter.cc:115:
> all_conditions_.push_back(std::move(condition_set));
> On 2015/11/18 16:18:53, Sorin Jianu wrote:
> > What is the reason for calling std::move? It seems that it is a container of
> > scoped_refptrs.
> 
> condition_set is a scoped_refptr. Moving it instead of copying saves one
> "roundtrip" of incrementing and decrementing the refcount.

Correct. It seems it is not idiomatic in the codebase to use move for such light
types though.

[Marc Treib, 2015-11-18 16:53:44]

On 2015/11/18 16:51:04, Sorin Jianu wrote:
> On 2015/11/18 16:33:37, Marc Treib wrote:
> > Thanks!
> > 
> >
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> > File chrome/browser/supervised_user/supervised_user_site_list.cc (right):
> > 
> >
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> > chrome/browser/supervised_user/supervised_user_site_list.cc:57: GURL
> > entry_point,
> > On 2015/11/18 16:18:53, Sorin Jianu wrote:
> > > ref to const?
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> > File chrome/browser/supervised_user/supervised_user_site_list.h (right):
> > 
> >
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> > chrome/browser/supervised_user/supervised_user_site_list.h:57: GURL
> entry_point,
> > On 2015/11/18 16:18:53, Sorin Jianu wrote:
> > > Pass GURL parameter by reference to const?
> > > Also, explicit is used for ctors with only one non-default params.
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> > File chrome/browser/supervised_user/supervised_user_url_filter.cc (right):
> > 
> >
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> > chrome/browser/supervised_user/supervised_user_url_filter.cc:57: std::string
> > hash = base::SHA1HashString(url.host());
> > On 2015/11/18 16:18:54, Sorin Jianu wrote:
> > > const?
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> > chrome/browser/supervised_user/supervised_user_url_filter.cc:115:
> > all_conditions_.push_back(std::move(condition_set));
> > On 2015/11/18 16:18:53, Sorin Jianu wrote:
> > > What is the reason for calling std::move? It seems that it is a container
of
> > > scoped_refptrs.
> > 
> > condition_set is a scoped_refptr. Moving it instead of copying saves one
> > "roundtrip" of incrementing and decrementing the refcount.
> 
> Correct. It seems it is not idiomatic in the codebase to use move for such
light
> types though.

It's not, because std::move was allowed just a few days ago.
If you have strong feelings about it, I can remove it - as you say, it won't
make much of a difference.

[Sorin Jianu, 2015-11-18 17:02:51]

On 2015/11/18 16:53:44, Marc Treib wrote:
> On 2015/11/18 16:51:04, Sorin Jianu wrote:
> > On 2015/11/18 16:33:37, Marc Treib wrote:
> > > Thanks!
> > > 
> > >
> >
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> > > File chrome/browser/supervised_user/supervised_user_site_list.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> > > chrome/browser/supervised_user/supervised_user_site_list.cc:57: GURL
> > > entry_point,
> > > On 2015/11/18 16:18:53, Sorin Jianu wrote:
> > > > ref to const?
> > > 
> > > Done.
> > > 
> > >
> >
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> > > File chrome/browser/supervised_user/supervised_user_site_list.h (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> > > chrome/browser/supervised_user/supervised_user_site_list.h:57: GURL
> > entry_point,
> > > On 2015/11/18 16:18:53, Sorin Jianu wrote:
> > > > Pass GURL parameter by reference to const?
> > > > Also, explicit is used for ctors with only one non-default params.
> > > 
> > > Done.
> > > 
> > >
> >
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> > > File chrome/browser/supervised_user/supervised_user_url_filter.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> > > chrome/browser/supervised_user/supervised_user_url_filter.cc:57:
std::string
> > > hash = base::SHA1HashString(url.host());
> > > On 2015/11/18 16:18:54, Sorin Jianu wrote:
> > > > const?
> > > 
> > > Done.
> > > 
> > >
> >
>
https://codereview.chromium.org/1443033004/diff/60001/chrome/browser/supervis...
> > > chrome/browser/supervised_user/supervised_user_url_filter.cc:115:
> > > all_conditions_.push_back(std::move(condition_set));
> > > On 2015/11/18 16:18:53, Sorin Jianu wrote:
> > > > What is the reason for calling std::move? It seems that it is a
container
> of
> > > > scoped_refptrs.
> > > 
> > > condition_set is a scoped_refptr. Moving it instead of copying saves one
> > > "roundtrip" of incrementing and decrementing the refcount.
> > 
> > Correct. It seems it is not idiomatic in the codebase to use move for such
> light
> > types though.
> 
> It's not, because std::move was allowed just a few days ago.
> If you have strong feelings about it, I can remove it - as you say, it won't
> make much of a difference.

that's ok, I was just trying to understand where this is coming from and learn
something.

[Marc Treib, 2015-11-18 18:15:12]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2015-11-18 18:15:12]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
sorin@chromium.org
Link to the patchset: https://codereview.chromium.org/1443033004/#ps80001
(title: "sorin review")

[commit-bot: I haz the power, 2015-11-18 18:16:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1443033004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1443033004/80001

[commit-bot: I haz the power, 2015-11-18 18:42:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-18 18:42:24]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Marc Treib, 2015-11-19 14:39:30]

Argh.. so the build failures on Android are because extensions/ isn't built on
Android (and anyway, code in components/ shouldn't depend on stuff from
extensions/, independent of the platform). I'll remove those parts.

[Bernhard Bauer, 2015-11-19 14:46:39]

On 2015/11/19 14:39:30, Marc Treib wrote:
> Argh.. so the build failures on Android are because extensions/ isn't built on
> Android (and anyway, code in components/ shouldn't depend on stuff from
> extensions/, independent of the platform).

(Note that the component updater has nothing to do with components/. Yeah, I
know 😃)

[Marc Treib, 2015-11-19 14:53:57]

On 2015/11/19 14:46:39, Bernhard Bauer wrote:
> On 2015/11/19 14:39:30, Marc Treib wrote:
> > Argh.. so the build failures on Android are because extensions/ isn't built
on
> > Android (and anyway, code in components/ shouldn't depend on stuff from
> > extensions/, independent of the platform).
> 
> (Note that the component updater has nothing to do with components/. Yeah, I
> know 😃)

Aaah you're right. I was confused because there is also a
components/component_updater/.

[Marc Treib, 2015-11-19 15:00:12]

Localization logic removed in PS 6. Does either of you want to take a look
again?

[Marc Treib, 2015-11-19 15:01:57]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-19 15:02:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1443033004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1443033004/100001

[Bernhard Bauer, 2015-11-19 15:04:54]

lgtm

[commit-bot: I haz the power, 2015-11-19 15:20:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 15:20:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Marc Treib, 2015-11-19 17:26:20]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2015-11-19 17:26:21]

The patchset sent to the CQ was uploaded after l-g-t-m from sorin@chromium.org
Link to the patchset: https://codereview.chromium.org/1443033004/#ps100001
(title: "remove l10n")

[commit-bot: I haz the power, 2015-11-19 17:26:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1443033004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1443033004/100001

[commit-bot: I haz the power, 2015-11-19 17:45:53]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-11-19 17:46:57]

Patchset 6 (id:??) landed as
https://crrev.com/d8a4b4663205374f77fac30e2bd07d247016fa9b
Cr-Commit-Position: refs/heads/master@{#360618}