Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 144303005: DevTools: Generate correct id for a remote target (Closed)

Created:
6 years, 10 months ago by Vladislav Kaznacheev
Modified:
6 years, 10 months ago
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Visibility:
Public.

Description

DevTools: Generate correct id for a remote target BUG=338303 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247949

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M chrome/browser/devtools/devtools_adb_bridge.cc View 6 chunks +12 lines, -9 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Vladislav Kaznacheev
6 years, 10 months ago (2014-01-29 14:54:45 UTC) #1
dgozman
If I understood correctly, we use remote_id to communicate with remote browser, and id_ to ...
6 years, 10 months ago (2014-01-29 15:07:16 UTC) #2
Vladislav Kaznacheev
On 2014/01/29 15:07:16, dgozman wrote: > If I understood correctly, we use remote_id to communicate ...
6 years, 10 months ago (2014-01-30 10:01:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/144303005/1
6 years, 10 months ago (2014-01-30 10:02:26 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 13:45:33 UTC) #5
Message was sent while issue was closed.
Change committed as 247949

Powered by Google App Engine
This is Rietveld 408576698