Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1442963002: [JSON stringifier] Reintroduce fast path with bail out to slow path. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[JSON stringifier] Reintroduce fast path with bail out to slow path. R=verwaest@chromium.org BUG=chromium:554946 LOG=N Committed: https://crrev.com/a7e50a5e06b2c7edd7915df774769c9add42be27 Cr-Commit-Position: refs/heads/master@{#31977}

Patch Set 1 #

Total comments: 1

Patch Set 2 : add more test cases #

Patch Set 3 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -5 lines) Patch
M src/json-stringifier.h View 3 chunks +57 lines, -5 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-554946.js View 1 2 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Yang
5 years, 1 month ago (2015-11-13 09:19:20 UTC) #1
Toon Verwaest
lgtm with nit. please add test that changes elements kind without changing length https://codereview.chromium.org/1442963002/diff/1/src/json-stringifier.h File ...
5 years, 1 month ago (2015-11-13 09:33:23 UTC) #2
Yang
fix tests
5 years, 1 month ago (2015-11-13 09:44:57 UTC) #3
Toon Verwaest
lgtm
5 years, 1 month ago (2015-11-13 09:45:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442963002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442963002/40001
5 years, 1 month ago (2015-11-13 09:45:43 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-13 10:09:37 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:21:18 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a7e50a5e06b2c7edd7915df774769c9add42be27
Cr-Commit-Position: refs/heads/master@{#31977}

Powered by Google App Engine
This is Rietveld 408576698