Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1442953002: Oilpan: turn MuteConsoleScope into a stack allocated object. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: turn MuteConsoleScope into a stack allocated object. Do so in order to have its embedded agent referenced be handled as required. R=keishi BUG=553613 Committed: https://crrev.com/794f5b73324b3b76a61fbbac54b1a94c71cb7152 Cr-Commit-Position: refs/heads/master@{#359538}

Patch Set 1 #

Patch Set 2 : fix init #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -13 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MuteConsoleScope.h View 1 1 chunk +25 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sof
please take a look.
5 years, 1 month ago (2015-11-13 10:13:41 UTC) #2
keishi
LGTM
5 years, 1 month ago (2015-11-13 10:22:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442953002/20001
5 years, 1 month ago (2015-11-13 11:09:36 UTC) #7
haraken
LGTM
5 years, 1 month ago (2015-11-13 11:36:06 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-13 12:58:52 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 13:00:46 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/794f5b73324b3b76a61fbbac54b1a94c71cb7152
Cr-Commit-Position: refs/heads/master@{#359538}

Powered by Google App Engine
This is Rietveld 408576698