media: Pass SetCdmReadyCB in {Audio|Video}Decoder::Initialize().

media: Pass SetCdmReadyCB in {Audio|Video}Decoder::Initialize().

This enables all audio/video decoders the ability to get access to the CDM
associated with the media element. This is useful for certain decoders to handle
encrypted streams.

For Decrypting{Audio|Video}Decoder and DecryptingDemuxerStream, the SetCdmReadyCB
is simply moved from constructor to Initialize() call. In the future this could
also help move Decrypting{Audio|Video}Decoder creation out of DecoderSelector so
that it is treated the same as all other decoders.

TBR=bbudge@chromium.org
BUG=545099
Committed: https://crrev.com/406d0255ae170720d2bc68cd7783855f16f3be17
Cr-Commit-Position: refs/heads/master@{#359702}

[xhwang, 2015-11-13 18:14:12]

Description was changed from

==========
media: Pass SetCdmReadyCB in {Audio|Video}Decoder::Initialize().

This enables all audio/video decoders the ability to get access to the CDM
associated with the media element. This is useful for certain decoders to handle
encrypted streams.

BUG=545099
==========

to

==========
media: Pass SetCdmReadyCB in {Audio|Video}Decoder::Initialize().

This enables all audio/video decoders the ability to get access to the CDM
associated with the media element. This is useful for certain decoders to handle
encrypted streams.

For Decrypting{Audio|Video}Decoder and DecryptingDemuxerStream, the
SetCdmReadyCB
is simply moved from constructor to Initialize() call. In the future this could
also help move Decrypting{Audio|Video}Decoder creation out of DecoderSelector so
that it is treated the same as all other decoders.

BUG=545099
==========

[xhwang, 2015-11-13 18:16:30]

xhwang@chromium.org changed reviewers:
+ dalecurtis@chromium.org, ddorwin@chromium.org, jrummell@chromium.org

[xhwang, 2015-11-13 18:16:30]

xhwang@chromium.org changed required reviewers:
+ jrummell@chromium.org

[xhwang, 2015-11-13 18:16:31]

jrummell: PTAL
dalecurtis: Please review the audio/video decoder API change.
ddorwin: FYI

[jrummell, 2015-11-13 19:52:12]

lgtm

[xhwang, 2015-11-13 19:54:05]

Description was changed from

==========
media: Pass SetCdmReadyCB in {Audio|Video}Decoder::Initialize().

This enables all audio/video decoders the ability to get access to the CDM
associated with the media element. This is useful for certain decoders to handle
encrypted streams.

For Decrypting{Audio|Video}Decoder and DecryptingDemuxerStream, the
SetCdmReadyCB
is simply moved from constructor to Initialize() call. In the future this could
also help move Decrypting{Audio|Video}Decoder creation out of DecoderSelector so
that it is treated the same as all other decoders.

BUG=545099
==========

to

==========
media: Pass SetCdmReadyCB in {Audio|Video}Decoder::Initialize().

This enables all audio/video decoders the ability to get access to the CDM
associated with the media element. This is useful for certain decoders to handle
encrypted streams.

For Decrypting{Audio|Video}Decoder and DecryptingDemuxerStream, the
SetCdmReadyCB
is simply moved from constructor to Initialize() call. In the future this could
also help move Decrypting{Audio|Video}Decoder creation out of DecoderSelector so
that it is treated the same as all other decoders.

TBR=bbudge@chromium.org
BUG=545099
==========

[xhwang, 2015-11-13 19:54:05]

xhwang@chromium.org changed reviewers:
+ bbudge@chromium.org

[xhwang, 2015-11-13 19:54:34]

TBRing bbudge for trivial changes in
content/renderer/pepper/video_decoder_shim.cc.

[bbudge, 2015-11-13 20:55:25]

content/renderer/pepper/video_decoder_shim.cc LGTM

[DaleCurtis, 2015-11-13 23:38:54]

api change lgtm, didn't review all the files.

[xhwang, 2015-11-13 23:41:13]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2015-11-13 23:42:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1442933002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1442933002/20001

[commit-bot: I haz the power, 2015-11-14 00:26:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-14 00:27:04]

Patchset 2 (id:??) landed as
https://crrev.com/406d0255ae170720d2bc68cd7783855f16f3be17
Cr-Commit-Position: refs/heads/master@{#359702}

[loyso (OOO), 2015-11-14 01:46:04]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1446713003/ by loyso@chromium.org.

The reason for reverting is: Mac build doesn't compile.

../../media/cast/sender/h264_vt_encoder_unittest.cc:140:43: error: too few
arguments to function call, expected 5, have 4
                   base::Unretained(this)));
                                          ^
../../media/filters/ffmpeg_video_decoder.h:42:3: note: 'Initialize' declared
here
  void Initialize(const VideoDecoderConfig& config,
  ^
1 error generated..