Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 14429004: Remove the compile and runtime flags for the JavaScript i18n API from Blink (Closed)

Created:
7 years, 8 months ago by Peter Beverloo
Modified:
7 years, 5 months ago
CC:
blink-reviews, haraken, jamesr, Nate Chapin, abarth_chromum.org, Nebojša Ćirić, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Remove the runtime flag for the JavaScript i18n API from Blink This feature is supported on all Chromium platforms and has no reason to be conditional anymore. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154005

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -17 lines) Patch
M Source/bindings/v8/V8WindowShell.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/page/RuntimeEnabledFeatures.in View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Peter Beverloo
The Chromium-sided patch should land first: https://codereview.chromium.org/13843008 For reference and discussion, see this CL: https://codereview.chromium.org/13725007/
7 years, 8 months ago (2013-04-23 13:27:13 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 8 months ago (2013-04-23 13:31:31 UTC) #2
jochen (gone - plz use gerrit)
is this going to land?
7 years, 5 months ago (2013-07-09 07:13:45 UTC) #3
Peter Beverloo
Apologies for the delay. I just put https://codereview.chromium.org/13843008/ on the commit queue which this depends ...
7 years, 5 months ago (2013-07-10 16:44:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/14429004/7001
7 years, 5 months ago (2013-07-11 10:57:53 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=12919
7 years, 5 months ago (2013-07-11 12:57:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/14429004/7001
7 years, 5 months ago (2013-07-11 13:22:27 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-11 14:00:48 UTC) #8
Message was sent while issue was closed.
Change committed as 154005

Powered by Google App Engine
This is Rietveld 408576698