src/x64/macro-assembler-x64.cc - Issue 14429003: Refactor ExternalReference::isolate_address() to not rely on Isolate::Current().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/macro-assembler-x64.cc

Issue 14429003: Refactor ExternalReference::isolate_address() to not rely on Isolate::Current(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/macro-assembler-x64.cc

diff --git a/src/x64/macro-assembler-x64.cc b/src/x64/macro-assembler-x64.cc

index 6e0734d594c84fe5f7a144ca7b785d2cc6825c6b..c193bb30fdd935a4e810e378128d7a2007f94589 100644

--- a/src/x64/macro-assembler-x64.cc

+++ b/src/x64/macro-assembler-x64.cc

@@ -818,9 +818,9 @@ void MacroAssembler::CallApiFunctionAndReturn(Address function_address,

movq(Operand(base_reg, kLimitOffset), prev_limit_reg);

movq(prev_limit_reg, rax);

#ifdef _WIN64

- LoadAddress(rcx, ExternalReference::isolate_address());

+ LoadAddress(rcx, ExternalReference::isolate_address(isolate()));

#else

- LoadAddress(rdi, ExternalReference::isolate_address());

+ LoadAddress(rdi, ExternalReference::isolate_address(isolate()));

#endif

LoadAddress(rax,

ExternalReference::delete_handle_scope_extensions(isolate()));

« no previous file with comments | « src/x64/deoptimizer-x64.cc ('k') | src/x64/regexp-macro-assembler-x64.h » ('j') | no next file with comments »