Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 14429002: Do not emit double values at their use sites. (Closed)

Created:
7 years, 8 months ago by Sven Panne
Modified:
7 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Do not emit double values at their use sites. Revert part of r14179. From the regression test's comment: Currently, the gap resolver doesn't handle moves from a ConstantOperand to a DoubleRegister, but these kind of moves appeared when HConstant::EmitAtUses was changed to allow special double values (-0, NaN, hole). So we should either enhance the gap resolver or make sure that such moves don't happen. BUG=chrome:234101 Committed: http://code.google.com/p/v8/source/detail?r=14394

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M src/hydrogen-instructions.h View 1 chunk +1 line, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-234101.js View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 8 months ago (2013-04-23 12:48:35 UTC) #1
mvstanton
Thanks for catching that Sven, looks good. I'll investigate handling things correctly in the gap ...
7 years, 8 months ago (2013-04-23 12:53:38 UTC) #2
Sven Panne
7 years, 8 months ago (2013-04-23 13:08:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14394 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698