generic method type parameter inference

pkg/analyzer/lib/src/generated/element.dart

Index: pkg/analyzer/lib/src/generated/element.dart
diff --git a/pkg/analyzer/lib/src/generated/element.dart b/pkg/analyzer/lib/src/generated/element.dart
index 7793d0d0b524d4ee4f7bf215e0c1805e7eeb3b73..78c483a6204a6344bdb7a24c7258a9466186d65c 100644
--- a/pkg/analyzer/lib/src/generated/element.dart
+++ b/pkg/analyzer/lib/src/generated/element.dart
@@ -9283,6 +9283,8 @@ class ParameterMember extends VariableMember
   @override
   Element get enclosingElement => baseElement.enclosingElement;
 
+  int get hashCode => baseElement.hashCode;

[Leaf, 2015/11/20 02:09:43]

@override?  Seems to be used elsewhere this is overriden.

[Jennifer Messerly, 2015/11/20 17:09:46]

Done.

+
   @override
   bool get isInitializingFormal => baseElement.isInitializingFormal;
 
@@ -9312,6 +9314,10 @@ class ParameterMember extends VariableMember
   SourceRange get visibleRange => baseElement.visibleRange;
 
   @override
+  bool operator ==(Object object) =>

[Leaf, 2015/11/20 02:09:43]

Was this a bug?  Why did this need to change?

[Jennifer Messerly, 2015/11/20 17:09:46]

yeah, generally these exist on Elements, and they can be compared for equality.

The bug with ParameterMember: every time you call FunctionTypeImpl.parameters,
it will make new ones, right? Because that's how it works: compute stuff on the
fly. So every time you call that, you get a new set of parameters. Since they
don't compare equal, you can never find what position you came from.

If you have a look over in this file, around line 1718:
https://codereview.chromium.org/1442883003/diff/140001/pkg/analyzer/lib/src/g...

you will notice I'm using .indexOf to find where the corresponding parameter
came from. That's not possible without this fix here.

+      object is ParameterMember && baseElement == object.baseElement;
+
+  @override
   accept(ElementVisitor visitor) => visitor.visitParameterElement(this);
 
   @override