Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1442853003: Removes the useless definition of GetAttributedSubstringFromRange. (Closed)

Created:
5 years, 1 month ago by Shu Chen
Modified:
5 years, 1 month ago
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes the useless definition of GetAttributedSubstringFromRange. BUG=121917 TEST=None TBR=asvitkine@chromium.org Committed: https://crrev.com/1f28f364c35131f731bb6fa6588a472b4675a7ba Cr-Commit-Position: refs/heads/master@{#359498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M content/browser/renderer_host/text_input_client_mac.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Shu Chen
TBR'ing asvitkine@ as this is really a trivial change.
5 years, 1 month ago (2015-11-13 04:55:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442853003/1
5 years, 1 month ago (2015-11-13 04:56:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 05:45:57 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1f28f364c35131f731bb6fa6588a472b4675a7ba Cr-Commit-Position: refs/heads/master@{#359498}
5 years, 1 month ago (2015-11-13 05:46:56 UTC) #7
Alexei Svitkine (slow)
5 years, 1 month ago (2015-11-13 16:01:49 UTC) #8
Message was sent while issue was closed. 
lgtm, though in the future I prefer not to be TBR'd unless you need to land
something really urgently which can't wait for my review. (e.g. fixing a
build break)

On Fri, Nov 13, 2015 at 12:46 AM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Patchset 1 (id:??) landed as
> https://crrev.com/1f28f364c35131f731bb6fa6588a472b4675a7ba
> Cr-Commit-Position: refs/heads/master@{#359498}
>
> https://codereview.chromium.org/1442853003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698