Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 144283012: DevTools: Move the fallback for not loaded resources to NetworkUISourceCodeProvider.js (Closed)

Created:
6 years, 10 months ago by sergeyv
Modified:
6 years, 10 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

DevTools: Move the fallback for not loaded resources to NetworkUISourceCodeProvider.js BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167184

Patch Set 1 #

Patch Set 2 : console.error was removed #

Total comments: 2

Patch Set 3 : Fix console.assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -54 lines) Patch
M Source/devtools/front_end/NetworkUISourceCodeProvider.js View 1 2 2 chunks +102 lines, -1 line 0 comments Download
M Source/devtools/front_end/Resource.js View 3 chunks +2 lines, -53 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sergeyv
6 years, 10 months ago (2014-02-12 13:32:31 UTC) #1
vsevik
lgtm https://chromiumcodereview.appspot.com/144283012/diff/30001/Source/devtools/front_end/NetworkUISourceCodeProvider.js File Source/devtools/front_end/NetworkUISourceCodeProvider.js (right): https://chromiumcodereview.appspot.com/144283012/diff/30001/Source/devtools/front_end/NetworkUISourceCodeProvider.js#newcode193 Source/devtools/front_end/NetworkUISourceCodeProvider.js:193: console.assert(false, "Resource content request failed. " + this._resource.url); ...
6 years, 10 months ago (2014-02-13 14:02:48 UTC) #2
sergeyv
https://codereview.chromium.org/144283012/diff/30001/Source/devtools/front_end/NetworkUISourceCodeProvider.js File Source/devtools/front_end/NetworkUISourceCodeProvider.js (right): https://codereview.chromium.org/144283012/diff/30001/Source/devtools/front_end/NetworkUISourceCodeProvider.js#newcode193 Source/devtools/front_end/NetworkUISourceCodeProvider.js:193: console.assert(false, "Resource content request failed. " + this._resource.url); On ...
6 years, 10 months ago (2014-02-13 14:14:13 UTC) #3
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 10 months ago (2014-02-13 14:14:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/144283012/70001
6 years, 10 months ago (2014-02-13 14:14:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 14:45:49 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) blink_heap_unittests, blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, ...
6 years, 10 months ago (2014-02-13 14:45:49 UTC) #7
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 10 months ago (2014-02-14 10:02:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/144283012/70001
6 years, 10 months ago (2014-02-14 10:02:59 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 12:12:56 UTC) #10
Message was sent while issue was closed. 
Change committed as 167184

Powered by Google App Engine
This is Rietveld 408576698