Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1442793002: Revert of Enabling included files when reloading local NTP with --local-ntp-reload. (Closed)

Created:
5 years, 1 month ago by kelvinp
Modified:
5 years, 1 month ago
Reviewers:
Mathieu, tmartino, fserb
CC:
chromium-reviews, David Black, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, Jered, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, melevin+watch_chromium.org, samarth+watch_chromium.org, skanuj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enabling included files when reloading local NTP with --local-ntp-reload. (patchset #7 id:120001 of https://codereview.chromium.org/1376243005/ ) Reason for revert: Break iOS Device ninja Build Bot https://build.chromium.org/p/chromium.mac/builders/iOS_Device_%28ninja%29/builds/29414 Compilation failed as In file included from ../../chrome/browser/search/local_files_ntp_source.cc:19: ../../third_party/re2/re2/re2.h:186:10: fatal error: 're2/stringpiece.h' file not found #include "re2/stringpiece.h" which is added in this CL. Original issue's description: > Enabling included files when reloading local NTP with --local-ntp-reload. TBR=fserb@chromium.org,mathp@chromium.org,tmartino@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/c4f7330abe94c5b80ec82ae9c312ad7ae52318b0 Cr-Commit-Position: refs/heads/master@{#359364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -55 lines) Patch
M chrome/browser/search/local_files_ntp_source.cc View 3 chunks +1 line, -55 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
kelvinp
Created Revert of Enabling included files when reloading local NTP with --local-ntp-reload.
5 years, 1 month ago (2015-11-12 19:55:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442793002/1
5 years, 1 month ago (2015-11-12 19:58:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442793002/1
5 years, 1 month ago (2015-11-12 20:04:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 20:08:42 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c4f7330abe94c5b80ec82ae9c312ad7ae52318b0 Cr-Commit-Position: refs/heads/master@{#359364}
5 years, 1 month ago (2015-11-12 20:09:37 UTC) #7
tmartino
5 years, 1 month ago (2015-11-12 22:37:18 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698