Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1442763002: Fix GrCoverageSetOpXP unit test on mixed samples (Closed)

Created:
5 years, 1 month ago by Chris Dalton
Modified:
5 years, 1 month ago
Reviewers:
egdaniel, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix GrCoverageSetOpXP unit test on mixed samples Updates GrCoverageSetOpXPFactory::TestCreate to not invert coverage with mixed samples, which is an unsupported configuration. TBR=bsalomon@google.com BUG=skia:4556 Committed: https://skia.googlesource.com/skia/+/c94cd7cc01b655b7f4289537962c36a4ee8dd63e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M include/gpu/GrProcessorUnitTest.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 1 chunk +1 line, -1 line 1 comment Download
M tests/GLProgramsTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Chris Dalton
5 years, 1 month ago (2015-11-12 19:44:44 UTC) #2
egdaniel
lgtm
5 years, 1 month ago (2015-11-12 19:54:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442763002/1
5 years, 1 month ago (2015-11-12 19:54:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/3859)
5 years, 1 month ago (2015-11-12 19:56:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442763002/1
5 years, 1 month ago (2015-11-12 20:10:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/c94cd7cc01b655b7f4289537962c36a4ee8dd63e
5 years, 1 month ago (2015-11-12 20:11:07 UTC) #11
bsalomon
5 years, 1 month ago (2015-11-12 21:08:28 UTC) #12
Message was sent while issue was closed.
otherwise lgtm

https://codereview.chromium.org/1442763002/diff/1/src/gpu/effects/GrCoverageS...
File src/gpu/effects/GrCoverageSetOpXP.cpp (right):

https://codereview.chromium.org/1442763002/diff/1/src/gpu/effects/GrCoverageS...
src/gpu/effects/GrCoverageSetOpXP.cpp:250: bool invertCoverage =
!d->fRenderTarget->hasMixedSamples() && d->fRandom->nextBool();
Can you add a comment here about why?

Powered by Google App Engine
This is Rietveld 408576698