Chromium Code Reviews

Issue 1442753008: Reserve space for scalar FP returns in the stack frame (Closed)

Created:
5 years, 1 month ago by sehr
Modified:
5 years, 1 month ago
Reviewers:
kschimpf, Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reserve space for scalar FP returns in the stack frame Rather than bumping the stack pointer around the scalar return sequence in _fld, ensure the prolog allocates enough space. BUG= R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=0d9cf4877c8524fc355a7b173123348661dc6bec

Patch Set 1 #

Patch Set 2 : Remove sub/add pair around returns from float functions #

Patch Set 3 : Add hyphen to comment #

Total comments: 1

Patch Set 4 : Code review comments #

Unified diffs Side-by-side diffs Stats (+27 lines, -20 lines)
M src/IceCfg.h View 1 chunk +1 line, -0 lines 0 comments
M src/IceInstX86BaseImpl.h View 4 chunks +5 lines, -15 lines 0 comments
M src/IceTargetLoweringX8632.cpp View 1 chunk +12 lines, -0 lines 0 comments
M tests_lit/llvm2ice_tests/commutativity.ll View 4 chunks +4 lines, -0 lines 0 comments
M tests_lit/llvm2ice_tests/elf_container.ll View 1 chunk +5 lines, -5 lines 0 comments

Messages

Total messages: 6 (2 generated)
sehr
One more sub/add pair moved to function frame computations.
5 years, 1 month ago (2015-11-16 20:22:00 UTC) #3
Jim Stichnoth
lgtm https://codereview.chromium.org/1442753008/diff/40001/src/IceTargetLoweringX8632.cpp File src/IceTargetLoweringX8632.cpp (right): https://codereview.chromium.org/1442753008/diff/40001/src/IceTargetLoweringX8632.cpp#newcode504 src/IceTargetLoweringX8632.cpp:504: Type ReturnType = Func->getReturnType(); const
5 years, 1 month ago (2015-11-16 23:54:09 UTC) #4
sehr
On 2015/11/16 23:54:09, stichnot wrote: > lgtm > > https://codereview.chromium.org/1442753008/diff/40001/src/IceTargetLoweringX8632.cpp > File src/IceTargetLoweringX8632.cpp (right): > ...
5 years, 1 month ago (2015-11-17 01:00:23 UTC) #5
sehr
5 years, 1 month ago (2015-11-17 01:00:42 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
0d9cf4877c8524fc355a7b173123348661dc6bec (tree was closed).

Powered by Google App Engine